title: Orbeon upgrade from 3.9 to 4.5 : Customized submit for saving forms
body: <p>We are upgrading from 3.9 to 4.5.</p>
  
  <p>In Some 3.9 Orbeon forms, We use customized submit button for save.</p>
  
  <p>This is not working in 4.5 Orbeon forms. When I click on "Submit", Its not saving the form to <code>orbeon_form_data</code> table.</p>
  
  <p>Below is the source code section for the "submit",</p>
  
  <pre><code>&lt;xhtml:head&gt;
      &lt;xforms:bind id="eoisave-btn-bind" ref="eoisave-btn" name="eoisave-btn" type="xforms:string"
                   relevant="$Bidlist_IsBidding != ''"/&gt;
  &lt;/xhtml:head&gt;
  &lt;xhtml:body&gt;
      &lt;fr:button id="eoisave-btn-control" bind="eoisave-btn-bind"&gt;
          &lt;xforms:label ref="$form-resources/eoisave-btn/label"/&gt;
          &lt;xforms:hint ref="$form-resources/eoisave-btn/hint"/&gt;
          &lt;xforms:alert ref="$fr-resources/detail/labels/alert"/&gt;
      &lt;/fr:button&gt;
      &lt;xforms:action ev:event="DOMActivate" ev:observer="eoisave-btn-control"&gt;
          &lt;xforms:setvalue if="xxforms:instance('fr-error-summary-instance')/valid = 'true'"
                           ref="./EOISaved"
                           value="1"/&gt;
          &lt;xforms:setvalue ref="./user-action"&gt;submit eoi&lt;/xforms:setvalue&gt;
          &lt;xforms:dispatch name="fr-save-action" target="fr-persistence-model"&gt;
              &lt;xxforms:context name="fr:check-data-valid" select="true()"/&gt;
          &lt;/xforms:dispatch&gt;
      &lt;/xforms:action&gt;
  &lt;/xhtml:body&gt;
  </code></pre>
  
  <p>And In the orbeon log, I can find the following.</p>
  
  <pre><code>+----------------------------------------------------------------------------------------------------------------------+
  |An Error has Occurred                                                                                                 |
  |----------------------------------------------------------------------------------------------------------------------|
  |Cannot compare xs:boolean to xs:string                                                                                |
  |----------------------------------------------------------------------------------------------------------------------|
  |Application Call Stack                                                                                                |
  |----------------------------------------------------------------------------------------------------------------------|
  |----------------------------------------------------------------------------------------------------------------------|
  |Exception: org.orbeon.saxon.trans.XPathException                                                                      |
  |----------------------------------------------------------------------------------------------------------------------|
  </code></pre>