I want to make sure I'm following industry standards and best practices with my first real crack at MVC.  In this case, it's ASP.NET MVC, using C#.I will be using Entity Framework 4.1 for my model, with code-first objects (the database already exists), so there will be a DBContext object for retrieving data from the database.In the demos I've gone through on the asp.net website, controllers have data access code in them.  This doesn't seem right to me, especially when following the DRY (don't repeat yourself) practices.For example, let's say I am writing a web application to be used in a public library, and I have a controller for creating, updating, and deleting books in a catalog.Several of the actions may take an ISBN and need want to return a Book object (note this is probably not 100% valid code):public class BookController : Controller{    LibraryDBContext _db = new LibraryDBContext();    public ActionResult Details(String ISBNtoGet)    {        Book currentBook = _db.Books.Single(b => b.ISBN == ISBNtoGet);        return View(currentBook);    }    public ActionResult Edit(String ISBNtoGet)    {        Book currentBook = _db.Books.Single(b => b.ISBN == ISBNtoGet);        return View(currentBook);    }}Instead, should I actually have a method in my db context object to return one Book?  That seems like it is a better separation to me, and helps promote DRY, because I might need to get a Book object by ISBN somewhere else in my web application.public partial class LibraryDBContext: DBContext{    public Book GetBookByISBN(String ISBNtoGet)    {        return Books.Single(b => b.ISBN == ISBNtoGet);    }}public class BookController : Controller{    LibraryDBContext _db = new LibraryDBContext();    public ActionResult Details(String ISBNtoGet)    {        return View(_db.GetBookByISBN(ISBNtoGet));    }    public ActionResult Edit(ByVal ISBNtoGet as String)    {        return View(_db.GetBookByISBN(ISBNtoGet));    }}Is this a valid set of rules to follow in the coding of my application?  Or, I guess a more subjective question would be:  is this the right way to do it?
Separating data access in ASP.NET MVC
c#;design patterns;asp.net mvc;industry standard
Generally, you want your Controllers to do only a few things:Handle the incoming requestDelegate the processing to some business objectPass the result of the business processing to the appropriate view for renderingThere shouldn't be any data access or complex business logic in the controller. [In the simplest of apps, you can probably get away with basic data CRUD actions in your controller, but once you start adding in more than simple Get and Update calls, you are going to want to break out your processing into a separate class.]Your controllers will usually depend on a 'Service' to do the actual processing work. In your service class you may work directly with your data source (in your case, the DbContext), but once again, if you find yourself writing a lot of business rules in addition to the data access, you will probably want to separate your business logic from your data access.At that point, you will probably have a class that does nothing but the data access. Sometimes this is called a Repository, but it doesn't really matter what the name is. The point is that all of the code for getting data into and out of the database is in one place.For every MVC project I've worked on, I've always ended up with a structure like:Controllerpublic class BookController : Controller{    ILibraryService _libraryService;    public BookController(ILibraryService libraryService)    {        _libraryService = libraryService;    }    public ActionResult Details(String isbn)    {        Book currentBook = _libraryService.RetrieveBookByISBN(isbn);        return View(ConvertToBookViewModel(currentBook));    }    public ActionResult DoSomethingComplexWithBook(ComplexBookActionRequest request)    {        var responseViewModel = _libraryService.ProcessTheComplexStuff(request);        return View(responseViewModel);    }}Business Servicepublic class LibraryService : ILibraryService{     IBookRepository _bookRepository;     ICustomerRepository _customerRepository;     public LibraryService(IBookRepository bookRepository,                            ICustomerRepository _customerRepository )     {          _bookRepository = bookRepository;          _customerRepository = customerRepository;     }     public Book RetrieveBookByISBN(string isbn)     {          return _bookRepository.GetBookByISBN(isbn);     }     public ComplexBookActionResult ProcessTheComplexStuff(ComplexBookActionRequest request)     {          // Possibly some business logic here          Book book = _bookRepository.GetBookByISBN(request.Isbn);          Customer customer = _customerRepository.GetCustomerById(request.CustomerId);          // Probably more business logic here          _libraryRepository.Save(book);          return complexBusinessActionResult;     } }Repositorypublic class BookRepository : IBookRepository{     LibraryDBContext _db = new LibraryDBContext();     public Book GetBookByIsbn(string isbn)     {         return _db.Books.Single(b => b.ISBN == isbn);     }     // And the rest of the data access}