I'm using QScintilla in my project.  There's no good FindQScintilla.cmake out there, so I'm writing one myself.  However, I don't really know what I'm doing.  This is my attempt; it works, but I don't know how it'll work in reality:find_path(QSCINTILLA_INCLUDE_DIR  NAMES Qsci qsciglobal.h  PATHS ${Qt5Core_INCLUDE_DIRS} /usr/include/x86_64-linux-gnu/qt5  PATH_SUFFIXES Qsci)find_library(QSCINTILLA_LIBRARY  NAMES qt5scintilla2 libqt5scintilla2  PATHS ${Qt5Core_LIBRARIES})include(FindPackageHandleStandardArgs)find_package_handle_standard_args(  QScintilla  FOUND_VAR QSCINTILLA_FOUND  REQUIRED_VARS QSCINTILLA_INCLUDE_DIR QSCINTILLA_LIBRARY  VERSION_VAR QSCINTILLA_VERSION)if(QSCINTILLA_LIBRARY AND QSCINTILLA_INCLUDE_DIR)  set(QSCINTILLA_LIBRARIES ${QSCINTILLA_LIBRARY})  set(QSCINTILLA_INCLUDE_DIRS ${QSCINTILLA_INCLUDE_DIR})endif()mark_as_advanced(QSCINTILLA_INCLUDE_DIR QSCINTILLA_LIBRARY)My development environment is Ubuntu 16.04, but I want this package to work on all major platforms.More specifically:Am I missing anything?How will this hold up on different operating systems?I'm targeting Windows, Mac, and Linux, though if there's a quick and easy way I can target another OS then I'll do that too.
FindQScintilla.cmake
cmake