Project Euler Problem 8 - Largest product in a series I am new to python3 and tried to solve the task in a very basic way. Please critique my code. I appriciate any suggestions for improvement.

Here is the question:


  The four adjacent digits in the 1000-digit number that have the
  greatest product are 9 × 9 × 8 × 9 = 5832.
  
  73167176531330624919225119674426574742355349194934
  96983520312774506326239578318016984801869478851843
  85861560789112949495459501737958331952853208805511
  12540698747158523863050715693290963295227443043557
  66896648950445244523161731856403098711121722383113
  62229893423380308135336276614282806444486645238749
  30358907296290491560440772390713810515859307960866
  70172427121883998797908792274921901699720888093776
  65727333001053367881220235421809751254540594752243
  52584907711670556013604839586446706324415722155397
  53697817977846174064955149290862569321978468622482
  83972241375657056057490261407972968652414535100474
  82166370484403199890008895243450658541227588666881
  16427171479924442928230863465674813919123162824586
  17866458359124566529476545682848912883142607690042
  24219022671055626321111109370544217506941658960408
  07198403850962455444362981230987879927244284909188
  84580156166097919133875499200524063689912560717606
  05886116467109405077541002256983155200055935729725
  71636269561882670428252483600823257530420752963450
  
  Find the thirteen adjacent digits in the 1000-digit number that have
  the greatest product. What is the value of this product?


My Code:

s = '7316717653133062491922511967442657474235534919493496983520312774506326239578318016984801869478851843858615607891129494954595017379583319528532088055111254069874715852386305071569329096329522744304355766896648950445244523161731856403098711121722383113622298934233803081353362766142828064444866452387493035890729629049156044077239071381051585930796086670172427121883998797908792274921901699720888093776657273330010533678812202354218097512545405947522435258490771167055601360483958644670632441572215539753697817977846174064955149290862569321978468622482839722413756570560574902614079729686524145351004748216637048440319989000889524345065854122758866688116427171479924442928230863465674813919123162824586178664583591245665294765456828489128831426076900422421902267105562632111110937054421750694165896040807198403850962455444362981230987879927244284909188845801561660979191338754992005240636899125607176060588611646710940507754100225698315520005593572972571636269561882670428252483600823257530420752963450'

listem = []
listem2 = []
highest = 1
pp = 13
sonuc = 1

for i in range(1001 - pp + 1):    
    listem.append(s[i: i+pp])
    for digit in listem[i]:
        listem2.append(digit)
    listem2 = [int(k) for k in listem2]
    for q in listem2:
        sonuc *= q
        if highest &lt; sonuc:
            highest = sonuc
    sonuc = 1
    listem2 = []

print(highest)
The easiest (but not computationally most efficient) way to solve this challenge is to use a brute-force algorithm, like you did. However you can write it a lot more succinctly when using more of the tools available in the Python standard library.


Use a generator expression to get all slices:

s = "..."
n = 13
slices = (s[i:i+n] for i in range(len(s) - n))
next(slices)
# '7316717653133'

map this string to an iterable of integers:

slices = (s[i:i+n] for i in range(len(s) - n))
list(map(int, next(slices)))
# [7, 3, 1, 6, 7, 1, 7, 6, 5, 3, 1, 3, 3]

Use functools.reduce and operator.mul to get the product of this iterable:

from functools import reduce
from operator import mul

slices = (s[i:i+n] for i in range(len(s) - n))
reduce(mul, map(int, next(slices)))
# 5000940

Use max to...get the maximum of those:

slices = (s[i:i+n] for i in range(len(s) - n))
max(reduce(mul, map(int, slice)) for slice in slices)

Finally, wrap the code in functions and the calling code in a if __name__ == "__main__": guard:

from functools import reduce
from operator import mul

def prod(x):
    return reduce(mul, x)

def maximum_product(s, n):
    return max(prod(map(int, s[i:i+n])) for i in range(len(s) - n))

if __name__ == "__main__":
    s = "..."
    n = 13
    print(max_product(s, n))