Why is my switch controlled receptacle always on?
See this little tab here?

Turn the power to this box off at the circuit breaker, and verify it's off. Then grab the little tab with a pair of needle nose pliers, and bend it back and forth until it breaks off.  Once you restore power, half of the receptacle will be controlled by the switch, while the other will be always on.

A couple other notes about your wiring
When wrapping wires around screw terminals, you always want to wrap them clockwise.  To tighten the screw you'll turn it clockwise, if the wire is wrapped clockwise it will be &quot;pulled in&quot; by the tightening action. If the wire is wrapped anticlockwise, the wire could be &quot;pushed out&quot; by the tightening action.

You'll also want to try and avoid getting insulation under the screw terminals. The insulation can prevent you from tightening the screw enough, which can lead to a poor connection.  A poor connection causes higher resistance, which increase heating, which leads to deterioration of the wiring, which leads to higher resistance, which leads to more heat, which leads to fire.