Unswitched to switched outlet?
First identify your switch leg. Turn off the power and disconnect the red and black wires and put wirenuts on the ends of them. Then turn the power back on using a non conducting power indicator, test the black and red for the wire that is permanently on. Then turning the switch off and on, identify the switch leg. Once you have done that then you know your wiring is connected properly to the box. 

Now turn the power back off and reconnect the permanently hot conductor back to the receptacle. Check to see if only one part of the receptacle is working. If only one is working, kill power and connect the switch leg to the other side of the receptacle and verify it is correct.

Point being, you have isolated the problem to either the wiring or the receptacle and either one or the other is incorrect. If it's the receptacle then I would just replace it. If it's the wiring you may have to start tracing backwards to the switch.

Good luck