Wiring receptacle(s) controlled by a switch
If I understand the diagram correctly, you connected hot from the duplex receptacle to the switch (correct) and then from the same screw on the switch to the single receptacle (wrong). You also connected neutral to the switch (wrong). Basically, you treated the switch as if it were another receptacle, when actually it should only be in the hot wire.

Remove both wires going to the bottom of the switch and connect them to each other (but not to the switch) with a wire nut. These wires should both be white because they are carrying neutral.
Disconnect the wire going from the top of the switch to the single receptacle and connect it to the bottom of the switch. This is switched hot - when the switch is on, it carries power from the hot wire (top of the switch, coming from the duplex receptacle) to the single receptacle. This wire (and the wire to the top of the switch) should be black (or any color other than white or green).

It doesn't matter whether you have hot on top/switched hot on bottom or vice versa - with a simple switch it doesn't matter.