smelling sink when using water after P-trap change
The most likely cause would be syphoning, where the flow of water in the waste pipe empties the P-trap. This could be due to too small a diameter pipe and/or lack of vent in the pipework to prevent a vacuum caused by draining water. Did you change any other pipework apart from the P-traps?