Replacing pool light switches with smart switches... is this correct?
Assuming both your switches and your GFCI have their line terminals on top and load terminals on the bottom, yes, this is correct.  Double-check that that's the case on your actual devices, because while the way you show it is common, I've seen some that are the opposite as well.  

Also, you should pigtail the ground to the GFCI -- it doesn't need to run through it, and you're supposed to wire it in such a way that if you remove one device, nothing else loses ground.  

Other than that, everything looks fine.