Wisconsin Basement Finishing questions
There are no red flags that I see in your question.  I don't like drylocking walls that will be covered in basements for the simple fact that if water hits concrete I would rather it go through the concrete than sit in the concrete (where if it freezes then expands will help promote larger cracks).  But you have 15 years there and nothing so good for you and with that track record I wouldn't worry about it.

I would personally run roxul in joists and then down a good foot or two below grade, with no vapor barrier (you already have drylock).  So what you have is insulation that does well in basements with drylock on one side and probably a decent air gap on the other and below.  Would spray foam be better... maybe.  It might insulate slightly better but then it is a mess if you do have a problem getting electric/plumbing out of the foam.

Moisture resistant sheet rock?  It doesn't matter unless you are having a lot of water gun fights in your basement.  The greenboard protects moisture from getting in the front (a little).  Any long-term moisture from the rear will effect it like it would regular drywall.  

Treated lumber?  Perfect.  He could have used treated lumber for everything but not required.  

You sound like you are off to a good start.  If you have more questions let us know.