Does this fill valve need replacing or should I replace cap? Its leaking
Looks fine, but what about the diaphragm/washer assembly? That is the stuff that gets soft and worn over time; you most certainly should replace that if ever you open up the cap...