Difficulty Designing A Product Database
I can only repeat what I tell everyone - Data Model Resource Book Volume 1 is maybe half about that topic and it is a serious goldmine of ideas and complications.

Seriously, depending what you want to cover that is a brutal topic. Some things are sized (3 x  2meter lone,  5x1.5 meter long), some have colors, some sizes, some colors AND sizes.

Price may depend on attribute, volume combined dimension (total meters). World of pain.

The question is how much of that you NEED - and what yo can cut.

I suggest reading the book for also in depth discussions about the topic.

Sadly, that is all I can say - without a requirement, a review of your schema is moot (did you forget something? How can I know... we only can check what is possible, not what is wanted, in product complexity).