Setting up Oracle publishers in SQL Server replication
Well after a call to microsoft I got the problem resolved.  Turns out it was an easy fix, SQL Server had to be restarted.  It looks like sql server was not picking up the updated path variable, so it wasn't finding the oracle binaries.  Luckily, while a production server, I was able to schedule a quick restart to resolve the problem.  After that sql was able to connect to the oracle database, for the rest I was able to follow microsoft's documentation pretty closely and get the replication working.

I wanted to make sure I update this, because I didn't see anything in the documentation saying sql had to be restarted after installing the oracle client, and hopefully it will be helpful to someone else.