Would these upgrades give me a better bike than I could buy with my budget plus the sale of my current bike?
$1K USD new would get you in the range of 9 speed Sora with a low to mid-range aluminum frame, so it wouldn’t be too bad of an option either. In the used market, you could likely get 105 11 speed mechanical on a mid-high end aluminum frame.
Those Campagnolo wheels appear to come with the campy freehub body, so you’ll need to factor in the cost of a conversion to HG for Shimano cassette compatibility.
If you’re happy with the 8 speed setup, go for it. If you want to go to Tiagra, then just buy a new or used bike with the additional budget. Having a shop install an entire groupset will get expensive quick. Speaking of which, how much of this work would you be willing/capable of doing yourself? Your own time and/or LBS expenses need to be factored in too.