About the BPSK signal waveform
If you can demodulate then it's probably correct. Perhaps it's just the fact that the carrier is not very fast that it looks weird. Can you increase the symbol period and the carrier frequency. Otherwise, my guess is that you are not convolving correctly. Just double-check if your RC has the correct width (or zero crossings). 
For reference I generated this:

Pulse-shaped BPSK with rect() through convolution:



Modulated by multiplying with the carrier tone:



Now with the raised-cosine pulse shape:



Note that by sampling at the correct times (each symbol period), we can recover the BPSK sequence perfectly.

Now modulated: