Improving an auto-correlation based guitar pitch detector
I realized I had forgotten to make an update to this.

I ended up following @robert bristow-johnson's recommendations in the comments.

I used time-domain McLeod Pitch Method in a live application (records audio in a loop) which works very well.

You can see the source code here:
https://github.com/sevagh/Pitcha