When should one change advisors? When should one keep going?
I would like to know what you would consider signs that it is better to change advisors?``


1) Not getting along 
2) Difference in methodology and study design 
3) not willing to discuss in depth your research plans
4) treat you as a lab technician (some people like this)
 5) harrassing ( mentally, physically, sexually)
 6)changing your thesis topic frequently/ not giving you title of your thesis for long time
7) not paying much attention to you or provide you with advice that cant benefit to your progress 
8) dont provide grant for your research
9) delaying consultations and skipping lab progress hours(consultation hours)
10) Steals your work 
11) No constructive criticism  

`What would you consider unfavourable in the advisor-advisee relationship but not detrimental to growth in research potential?


wy advisor look, talk and personally behave, these things shouldnt influence research potential 

 What constitutes a good advisor-advisee relationship in your opinion?


You can become independent researcher and valuable contributor to science after finishing PhD. Your advisor method and behavior can shape you in adequate PhD holder

How does all this depend on where someone is in graduate school at the moment (e.g. 1st year masters vs 3rd year PhD)?
it is much easier to change advisors and programs in 1st year of master then in 3rd year of PhD, procedure is really hard, especially when you are until the end of studies

 What would the ideal advisor-advisee relationship look like?


I dont know, there is no unique example, everyone is different, you need to get along that is for sure, ideal situation for me is not ideal for you,
I like advisors that can be there all the time, some people and student like different style, important thing is that you can benefit from your advisor in professional sense !