Problem sharing via email in Photos app on Mac
For me, (with the same problem), the issue was that Apple Mail was not the default mail client (Thunderbird was).

Mail > Preferences > General 

Changed "default email reader" to Mail.app and Presto!  email appeared in the share menu.