How to diagnose Finder losing icons for folders?
try this in Terminal

mkdir ${TMPDIR}/com.apple.IconServices 

This recreates the com.apple.IconServices directory, which apparently gets itself deleted from time to time.