iTerm2 settings are reset upon app close
When I transferred my iTerm2 profiles over from Mavericks to Yosemite I ran into the same problem. I found that apple caches application preferences so after you make the changes try running sudo killall cfprefsd to clear to preference cache. This seemed to do the trick for me.