Icons not appearing on High Sierra
Give this a try. 

sudo find /private/var/folders/ -name com.apple.iconservices -exec rm -rf {} \;
sudo rm -rf /Library/Caches/com.apple.iconservices.store
killall Dock


After running the commands, I had to remove the app from the dock and add it again. It worked for me but YMMV.