If somebody has logged onto my iCloud account can they see what I buy or download on the App Store?
Yes and no - not directly. That person would have to set up iTunes with your Apple ID and then browse through the list of purchased apps.