iCloud keychain authorisation sends sms to old number
On your iPhone, go to Settings → iCloud → Keychain and switch Keychain off then on again.
Tap "Approve with Security Code", tap "Forgot Code" and then tap "Reset".
Follow the instructions to reset iCloud keychain and create a new passcode.

You will then be prompted to update to your new number.