What is causing my ~/Library folder to be come visible again?
It is VueScan. The developer (who otherwise is great) does annoying things like this, or adding the app's icon to the Dock without making them a preference.