Why does show hidden files shortcut only work intermittently?
I've run across this recently and the way I got it working again was to "refresh" the Finder window.  Since there's no refresh F5 like there is in Windows, you have to move out of the directory and then back in.  Additional, you can close the Finder window and reopen it. 

It seems to be a bug within Finder