Can't Turn off Finder Tabs on Mojave
I believe that the option only works when opening folders directly from a Finder window. If you CMD-click on Favorites, then a new tab is opened if the preference is On. And a new window is opened if the preference is Off.