iPhone 4 having trouble connecting with dock
Have you tried looking inside your iPhone side of the connector?  I've noticed that a lot of pocket lint tends to build up in there over time and I just took a toothpick and dug all of it out.  My wife's iPhone wasn't syncing when connected to my laptop and this turned out to be the issue.