How to remove iCloud alert badge from macOS settings icon
Did you try to sign out from iCloud an the App Store and rebooting your Mac?
This solved the problem for many people I know...

I hope this helps!!