Finder not showing DVD/CD drive even when it is checked in the Preferences
From comments, it seems like a simple 'wrong pref'.
The pref in the posted image is for Desktop visibility.
To show in the Finder sidebar, the one required is in the 3rd tab, Sidebar.