Texting from my old 3GS iphone without a Sim still shows my old phone number
Cellular SMS requires an activated SIM card.

When you upgraded to a 4s, the phone company probably deactivated the SIM in your 3GS, so it can't be used for SMS without another valid SIM card.