What files should I delete before giving my MacBook to someone else?
Since you are not giving it to some unknown 3d person there is no need to completely erase the drive and reinstall operating system.

You can use the

mdfind in Terminal

for example mdfind user will list all files for the current user

It will even show the deleted files

mdfind user youroldusername 


will show your files if any are left.