What happens if you uncheck iCloud for photos?
If you are using iCloud photos somewhere else all turning it off does is stops them from updating on your mac. Your photos won't get deleted immediately from iCloud if you turn it off and you only have it turned on o your mac, and they will stay on your mac.