Why can my iMac see my Macbook pro with 2 different icons on the network sharing? (as if it were 2 devices)
You answered it yourself. You had both AFP and SMB network sharing protocols enabled. Thus your mac was presented as two network devices. Notebook icon is for AFP shares and generic PC one is for SMB.

No need to worry about that since it is normal behaviour.