Search in Apple Notes.app for MacOS does not work at all
For a search to work you have to tell the search function where to search. So if you put the notes on the icloud drive you want to click on that and then search. The search function works fine on Notes as it searches inside each note.