Symlink dotfiles to Documents/Dotfiles
man ln clearly says:

ln [-Ffhinsv] source_file [target_file]


So yeah, your command seems reasonable.

The script, however, is odd. makeLinks is never invoked and the prompt asking for confirmation would just cause recursion. You probably meant to place it outside the function definition.