Replace AMS1117 5V-3.3V LDO on NodeMCU for LiPo with low quiescent current
You choice looks good to me, but only if your NodeMCU is going to spend most of its time sleeping. In that case I'd use a MCP1700 (quiescent current &lt; 4 uA).

If it's going to spend a significant % of time up and running you may be better off using a switching regulator. It's all about considering the energy saved when it's sleeping vs. the energy saved when it's operating.