Power Consumption of a sensor
The formula to get average current consumption over one ON/OFF cycle is:
$$I_{avg} = \frac{I_{ON} \times t_{ON} + I_{OFF} \times t_{OFF}}{t_{cycle}}$$
Your error is that you did not normalize the average current calculation by the complete cycle time.
Then it is straightforward to get expected battery life as you did.