Some help with 9V Longlife VARTA batteries?
You are probably shorting out the battery when the switch is in the 'off' position- the schematic you show won't work (battery is shorted either way), so the real schematic must be a bit different. 

Use the below schematic. Only two connections to the switch (leave the other one open) and only on one side of the battery. 





It still won't be great- you'll most likely get much better performance in light per unit of currency by using 6 AA batteries in series rather than a 9V battery.