Solar Panel-Photocell Wiring
Your diagram is wrong.
Based on the labels on the photo-switch in this image.


Connect battery negative, controller P- and photoswitch white wire together  
Connect Battery positive to photoswitch black wire
Connect photoswitch red wire to controller P+


If that does not work the photoswitch may be dead.