Checking for short vs long press with debounce
Never used Arduino, but don't you need to use double equal signs in a compare function?

So, if (rotaryButtonToAction = noPress) should be if (rotaryButtonToAction == noPress) instead?