Update role with hook user update
hook_user_update : Modules may use this hook to update their user data in a custom storage after a user account has been updated. 

So that hook is call only when you edit the user account. other things is disable you module which implement this hook.

Morever if you want to edit the role every time when user is created/edited use hook_user_presave.