How to attach a date field from another entity to a new form
Unsurprisingly, it was my error.  

Further up in my function I was building $form_state with form_state_defaults().  Once I provided a proper form_state everything worked as expected.