When should field_attach_load be called manually?
api.drupal.org says:


  field_attach_load() is automatically called by the default entity
  controller class, and thus, in most cases, doesn't need to be
  explicitly called by the entity type module.


Basically only call it if you're implementing an entity type and don't want to use the default entity controller. I'm pretty sure ClosedQuestion is in the wrong, since it's only making a node type. All fields should be attached by the time hook_load() comes along.