Who built the LEGO structures for the film "Elf"?
According to an interview with Elf director Jon Favreau, the Lego City set was built in-house by the Rusty Smith's art department. 

The IMDB page for the movie thanks The LEGO Group for the permission to use the LEGO logo and trademarks but has no mention of any further involvement in set design.