A small emacs-lisp snippet for opening a register in another window
The first things which jump into my face are the broken indentation and a dangling parenthesis. Please fix them, otherwise the code is not very readable.

More to the point, I think it is better to replace the body with

(switch-to-buffer-other-window (register-buffer register-name))


and define

(defun register-buffer (register-name)
  (save-window-excursion 
    (jump-to-register register-name)
    (current-buffer)))