Pseudo-random number generator port from C
I cannot see any functional issues when comparing the C code against the Java code. it would seem they should produce the same results given the same input. Of course, a logical course of action would be to write a test system for the code which wraps the C code in to a program which accepts a single seed value as an argument, and produces a stream of int values in 'network byte' order. You then pipe that stream in to a Java program which produces the same stream, and compares the results. I would actually set up a test where the Java program starts a sub-process for the C version, and runs it with many input seeds, including the logical edge-cases (0, 1, -1, Long.MAX_VALUE, Long.MinValue, and all seeds from -100 to +1000). For each run, compare the first 10,000 generated values.

That would give me some measure of confidence that the code is a faithful reproduction.

Like you, I believe the Java code is a fair reproduction, but, like you, I would want to check it again.

Now,about the code, you are doing unnecessary work. There is no need to store the oldState:


public int nextInt() {
  long oldState = state;
  state = oldState * MULTIPLIER + inc;
  int xorShifted = (int) (((oldState &gt;&gt;&gt; 18) ^ oldState) &gt;&gt;&gt; 27);
  int rot = (int) (oldState &gt;&gt;&gt; 59);
  return Integer.rotateRight(xorShifted, rot);
}



That code can be reduced to:

public int nextInt() {
  int xorShifted = (int) (((state &gt;&gt;&gt; 18) ^ state) &gt;&gt;&gt; 27);
  int rot = (int) (state &gt;&gt;&gt; 59);
  state = state * MULTIPLIER + inc;
  return Integer.rotateRight(xorShifted, rot);
}


Also, while your comments about the &gt;&gt;&gt; vs &gt;&gt; are accurate, and I prefer the use of &gt;&gt;&gt; here, you should also know that the only shift which has a significant impact (where using &gt;&gt;&gt; makes a difference vs. &gt;&gt;) is the part:

(state &gt;&gt;&gt; 18)


In that shift, if it was a negative state, and you used &gt;&gt;, it would shift the sign bit to position 46 (and all higher bits). Then the subsequent &gt;&gt;&gt; 27 would shift those effects in to the low-order 32-bits. Since the value is truncated to 32 bits, any sign-shift effects which happen above 32 bits are irrelevant, and as I say, the only sign-shift which can effect the low 32 bits is the first one.

Also, Java uses a mask on the int rotate value, and for Integer.rotateRight it only considers the low-5 bits in the value, so the following are identical because the rotate effectively applies the mask 0x1f to the value anyway:

Integer.rotateRight(xorShifted, (int)(oldState &gt;&gt;&gt; 59))
Integer.rotateRight(xorShifted, (int)(oldState  &gt;&gt; 59))


You may want to test the performance of each, and exercise your profiler....