Changing visibility of ToolbarItem - Xamarin.Forms
Two things:


You clear ToolbarItems and CustomToolbar when page dissapearing, this causes problem: when you show next page and then go back, you won't see your items anymore, because they were cleared.
Handlers OnToolbarItemPropertyChanged will not be removed in foreach cycle, because you clear list before this cycle.