Synchronized block over concurrent collections
It looks like you are trying to re-invent the CopyOnWriteArrayList.

By the way, Vector is very old fashioned, but I guess you are working with legacy code.  The code also does not use generics.  CopyOnWriteArrayList started with Java 5, so might not be able to use it if you are stuck with an older Java version.