Cutting Square Hole In a Cylinder
Here is a way to do it, but if you want to avoid any pinching it needs more geometry than on your screenshot. Once done, you can delete the useless geometry, i.e. vertical edge loops on the rest of the cylinder: