Pierce a hole on the edge of a cylinder
Edit: I've edited my post as, at first, I didn't understand your question

The easiest way would be this one:


Create 2 circles
Merge them
Delete some vertices
Fulfill the shape with F
Extrude with E and press Z to constraint on the Z axis


but it also depends on what you want to do with this shape later on