How to approximate the pH of a box of water molecules with one proton?
For a rough, back of the envelope, sanity check sort of calculation, your second approach is more appropriate than the first. (Though check your value for Avogadro's number.) This is something that should jump out at you if you keep track of units in your calculation. The $\ce{[H+]}$ in the equation should be measured in moles of hydrogen ion per liter, so your calculation needs to result in an inserted value that's in moles of hydrogen ion per liter. You can also rule out the first equation by performing a thought experiment: if the size of the box doesn't factor into the equation, does it make sense that the pH wouldn't change if the box size changes? (No matter how much the size changes?)

However, the statement that pH is equal to the negative log of the hydrogen ion concentration is strictly speaking only true for dilute aqueous solutions near standard temperature and pressure. For concentrated acids/bases, solutions which are not primarily water, or for pressure and temperatures well outside standard, things get more contentious. There's a number of different interpretations of what "pH" means, and each have their advantages/disadvantages, depending on the situation.

One of the big considerations here is that "concentration" is not really really the thermodynamically relevant parameter when figuring out how chemical systems behave. Instead, it's the compound activity which is typically the more important quantity to keep track of. As it happens, the thermodynamic activity of a compound is normally proportional to the concentration in dilute solutions, so by convention we set unit activity to be equivalent to 1M solution.* This means the distinction between concentration and activity is normally ignored/glossed over in most introductory chemistry courses, but make no mistake, it's the activity of the compounds which should be used in things like the Henderson–Hasselbalch equation, not the concentration.

*(This normalization by 1 mol/L is the reason we can take the log and not run up against any strange results with dimensional analysis - it's technically a dimensionless value inside the log: the actual concentation, divided by the reference concentration of 1 M.)

The reason this matters for you is that you're dealing with a situation which isn't quite the same as a dilute aqueous solution. Nominally, it sounds like you're close. Your water density is around standard water density, and the amount of hydrogen ions are close to 1 mole per litre. But there are other considerations to take in to account. For example, what temperature and pressure are you using? Extreme values can change the hydrogen ion activity. Also, you didn't mention anything about the presence of a counter-ion. The unbalanced electrical charge might affect the predicted activity as well. The other issue is that just a single hydrogen ion will result in some pretty extensive fluctuations in the system as the system changes state. The "pH" (or hydrogen ion activity) of the system may actually exhibit time dependence, which might be important for the system you're modeling. 

If you're truly interested in what the equivalent pH of the solution is, you should look into simulation techniques which attempt to actually gauge the chemical activity of the hydrogen ion under the conditions you're interested in. -- That is, figure out why you want to know the "pH" of the system, and look for more direct measures of that.