Commerce 2 Sales Not Present In Cart lineItems
After further testing and debugging, it turns out these issues are related to this bug in Commerce:

https://github.com/craftcms/commerce/issues/1206

As per that github issue, it was a Discount with Ignore sales when this discount is applied enabled that was the culprit, but shouldn't be once that bug is fixed.