Using Craft environment variable for Asset source subfolder
From the docs, environment variables are currently only parsed in 3 places in the control panel. 


File System Path (in asset source settings)
URL (in asset source settings)
Site URL (in Settings → General)


So they won't work in the "subfolder" setting.  You can add a feature request if you think that should change.