decision making process and just pick the value from the proper place.
Is this going to bite anyone during bisection of this patch series?
No. I misused the word "initialized" there. I probably should have just said "set". The virDomainActualNetDef *is* "properly initialized" to NULL, and when it's null, all behavior with this patch in place is identical to what it would have been without the patch. What is being assumed here is that an ActualNetDef might really be present, but one never is, that's all.
and replace all uses of iface->type with virDomainNetGetActualType().
We can't replace *all* uses. There are times when we want to know the original type.
because 1) the code that added the ActualNetDef also ensured that it was always initialized to NULL, 2) there was no place in the code that changed the ActualNetDef, and 3) if the ActualNetDef is NULL, virDomainNetGetActualType will *always* return iface->type.
adding new code (taking action if actualType is TYPE_BRIDGE).
make review a bit easier.
Okay, I can agree with that. I can put that in a different patch.
Need to check for strdup failure, rather than setting dev to NULL.
Yep. I missed that one.