'use strict';

import { LOGOUT } from 'app/actions/auth';
import {
  SET_PAGE_LOGIN_STATE,
  SET_PAGE_SIGNUP_STATE,
  SET_OVERRIDE_FRAME,
  CLEAR_OVERRIDE_FRAME
} from 'app/actions/landingPage';
import { initialLPState } from 'app/constants';

export default function landingPageState(state = initialLPState, action) {
  switch (action.type) {
    case SET_PAGE_LOGIN_STATE:
      return { ...state, frame: 'login' };
    case SET_PAGE_SIGNUP_STATE:
      return { ...state, frame: 'signup' };
    case SET_OVERRIDE_FRAME:
      return { ...state, overrideFrame: action.frame };
    case CLEAR_OVERRIDE_FRAME:
    case LOGOUT:
      return initialLPState;
  }

  return state;
}

'use strict';

import { API_LOGIN_SUCCESS, API_SIGNUP_SUCCESS } from 'app/actions/auth';
import {
  SET_PAGE_LOGIN_STATE,
  SET_PAGE_SIGNUP_STATE,
  SET_OVERRIDE_FRAME,
  CLEAR_OVERRIDE_FRAME
} from 'app/actions/landingPage';
import { initialLPState } from 'app/constants';

export default function landingPageState(state = initialLPState, action) {
  switch (action.type) {
    case SET_PAGE_LOGIN_STATE:
      return { ...state, frame: 'login' };
    case SET_PAGE_SIGNUP_STATE:
      return { ...state, frame: 'signup' };
    case SET_OVERRIDE_FRAME:
      return { ...state, overrideFrame: action.frame };
    case CLEAR_OVERRIDE_FRAME:
    case API_LOGIN_SUCCESS:
    case API_SIGNUP_SUCCESS:
      return initialLPState;
  }

  return state;
}

--- 
+++ 
@@ -1,6 +1,6 @@
 'use strict';
 
-import { API_LOGIN_SUCCESS, API_SIGNUP_SUCCESS } from 'app/actions/auth';
+import { LOGOUT } from 'app/actions/auth';
 import {
   SET_PAGE_LOGIN_STATE,
   SET_PAGE_SIGNUP_STATE,
@@ -18,8 +18,7 @@
     case SET_OVERRIDE_FRAME:
       return { ...state, overrideFrame: action.frame };
     case CLEAR_OVERRIDE_FRAME:
-    case API_LOGIN_SUCCESS:
-    case API_SIGNUP_SUCCESS:
+    case LOGOUT:
       return initialLPState;
   }
 
Reset landing page state only upon logout

This change prevents the signup and login page analytics events to be
fired erroneously. [Finishes #133219321]
