The iPhone XR might be the newer phone here but iPhone X owners won't be upgrading. The original X has a better screen, cameras and a more premium build. If you do switch, it will be namely for the colours the XR offers. You'll also get a better processor but that shouldn't matter.