text:
May 7, 2008:
- 11:12 PM SquirrelFishBlockers edited by
- (diff)
- 11:11 PM Changeset in webkit [32971] by
- 13 edits2 adds in branches/squirrelfish/LayoutTests
o2008-05-07 Geoffrey Garen <firstname.lastname@example.com>
Reviewed by Oliver Hunt.
Added this test to demonstrate that, for "f(x)", it is correct to evaluate
"x" even if "f" is not a function, and therefore "f(x)" will throw an exception.
- fast/js/function-argument-evaluation-before-exception-expected.txt: Added.
- fast/js/function-argument-evaluation-before-exception.html: Added.
These tests now have an extra "access denied" message in them, because
of the behavior change mentioned above.
I also added try/catch clauses to eliminate the "is not object"
exception messages from the test output.
- http/tests/security/listener/resources/targetChild-JSTargetNode-onclick-addEventListener.html:
- http/tests/security/listener/resources/targetChild-JSTargetNode-onclick-shortcut.html:
- http/tests/security/listener/resources/targetChild-XMLHttpRequest-addEventListener.html:
- http/tests/security/listener/resources/targetChild-XMLHttpRequest-shortcut.html:
- http/tests/security/listener/resources/targetChild-window-onclick-addEventListener.html:
- http/tests/security/listener/resources/targetChild-window-onclick-shortcut.html:
- http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt:
- http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt:
- http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt:
- http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt:
- http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt:
- http/tests/security/listener/xss-window-onclick-shortcut-expected.txt:
- 10:16 PM SquirrelFishBlockers edited by
- (diff)
- 9:36 PM Changeset in webkit [32970] by
- 11 edits in branches/squirrelfish/LayoutTests
2008-05-07 Geoffrey Garen <firstname.lastname@example.com>
Reviewed by Oliver Hunt.
Fixed up a few more tests that depended on the exact text of exception
- In these tests, I fixed a bug in frame.html and iframe.html that caused a function to execute too many times.
- dom/html/level2/html/HTMLFrameElement09-expected.txt:
- dom/html/level2/html/HTMLIFrameElement11-expected.txt:
- dom/html/level2/html/resources/frame.html:
- dom/html/level2/html/resources/iframe.html:
- I changed these tests to explicitly report exceptions, so their results don't depend on how the engine constructs messages for implicit exceptions:
- dom/xhtml/level2/html/HTMLDocument17-expected.txt:
- dom/xhtml/level2/html/HTMLDocument18-expected.txt:
- dom/xhtml/level2/html/HTMLDocument19-expected.txt:
- dom/xhtml/level2/html/HTMLDocument20-expected.txt:
- dom/xhtml/level2/html/HTMLDocument21-expected.txt:
- dom/xhtml/level2/html/selfxhtml.js:
- 8:28 PM Changeset in webkit [32969] by
- 2 edits in trunk/LayoutTests
2008-05-07 Stephanie Lewis <firstname.lastname@example.com>
fix messed up result
- fast/events/onunload-not-on-body-expected.txt:
- 7:13 PM Changeset in webkit [32968] by
- 5 edits in trunk/WebCore
2008-05-07 Sam Weinig <email@example.com>
Reviewed by Adele Peterson
Update MessageEvent to match the latest version of the HTML5 spec,
adding the lastEventId attribute.
- dom/MessageEvent.cpp: (WebCore::MessageEvent::MessageEvent): (WebCore::MessageEvent::initMessageEvent):
- dom/MessageEvent.h: (WebCore::MessageEvent::lastEventId):
- dom/MessageEvent.idl:
- page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage):
- 6:05 PM Changeset in webkit [32967] by
- 4 edits2 adds in trunk
2008-05-07 Stephanie Lewis <email@example.com>
Reviewed by Maciej.
remove non-functioning code. If onunload should be fired from these nodes then
a WindowEventListener needs to be set. However, Firefox and IE also do not
fire onunload events for these cases.
Test: fast/events/onunload-not-on-body.html
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::parseMappedAttribute):
- html/HTMLObjectElement.cpp (WebCore::HTMLObjectElement::parseMappedAttribute):
Test onunload attr on a frame does not call onunload, but that an onunload attr on the body of
a frame does. Also test that onunloads on object elements are not called.
- fast/events/onunload-not-on-body-expected.txt: Added.
- fast/events/onunload-not-on-body.html: Added.
- 1:44 PM Changeset in webkit [32966] by
- 4 edits4 adds in trunk
Reviewed by John Sullivan.
- fix https://bugs.webkit.org/show_bug.cgi?id=18909 <rdar://problem/5914165> REGRESSION (r31872-r31878): Viewed photos not closing completely at indycar.com
Test: fast/dynamic/positioned-movement-with-positioned-children.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutOnlyPositionedObjects): Cover the case of a positioned object that has only moved and has only positioned children that have changed.
- rendering/RenderObject.h: (WebCore::RenderObject::needsPositionedMovementLayout): Added this accessor.
Reviewed by John Sullivan.
- test for https://bugs.webkit.org/show_bug.cgi?id=18909 <rdar://problem/5914165> REGRESSION (r31872-r31878): Viewed photos not closing completely at indycar.com
- fast/dynamic/positioned-movement-with-positioned-children.html: Added.
- platform/mac/fast/dynamic/positioned-movement-with-positioned-children-expected.checksum: Added.
- platform/mac/fast/dynamic/positioned-movement-with-positioned-children-expected.png: Added.
- platform/mac/fast/dynamic/positioned-movement-with-positioned-children-expected.txt: Added.
- 1:41 PM Changeset in webkit [32965] by
- 4 edits in trunk/WebCore
2008-05-07 Anders Carlsson <firstname.lastname@example.com>
Reviewed by John.
When no document loaders are associated with an application cache group,
release the reference to the newest cache group. This prevents reference cycles.
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): (WebCore::ApplicationCacheGroup::documentLoaderDestroyed): (WebCore::ApplicationCacheGroup::cacheDestroyed):
- loader/appcache/ApplicationCacheGroup.h:
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::cacheGroupForURL): Return early if the datbase wasn't open.
Add error.
- 12:42 PM Changeset in webkit [32964] by
- 2 edits in trunk/WebCore
2008-05-07 Anders Carlsson <firstname.lastname@example.com>
Reviewed by Adam.
Don't put pages with an application cache in the BF cache.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::canCachePage):
- 11:59 AM Changeset in webkit [32963] by
- 4 edits4 adds in trunk
2008-05-07 Justin Garcia <firstname.lastname@example.com>
Reviewed by John Sullivan.
<rdar://problem/5666354> Crashes in Mail at WebCore::RemoveNodeCommand::doApply
When a single tab or series of tabs was copied, we weren't putting them into a
tab span. On Paste, we would be given a text node with a single tab or series
of tabs in it, and we would crash when inserting it at the start of a block
(where that kind of text becomes completely unrendered).
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds): Clean up correctly and early return if we removed everything that was inserted.
- editing/markup.cpp: (WebCore::createMarkup): Include the tab span when the only thing copied was a tab or a series of tabs.
2008-05-07 Justin Garcia <firstname.lastname@example.com>
Reviewed by John Sullivan.
<rdar://problem/5666354> Crashes in Mail at WebCore::RemoveNodeCommand::doApply
- editing/pasteboard/5761530-1-expected.txt: Added.
- editing/pasteboard/5761530-1.html: Added.
- editing/pasteboard/5761530-2-expected.txt: Added.
- editing/pasteboard/5761530-2.html: Added.
- 11:02 AM Changeset in webkit [32962] by
- 2 edits in trunk/WebKit/mac
2008-05-07 Anders Carlsson <firstname.lastname@example.com>
Reviewed by Mitz.
REGRESSION (3.1.1-TOT): Arrow keys are sticky in Google Maps street view
Stop suspending key up events before calling handleEvent.
- Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::sendEvent):
- 10:33 AM Changeset in webkit [32961] by
- 2 edits in trunk
Added radar to changelog for r32959.
- 10:16 AM Changeset in webkit [32960] by
- 6 edits in trunk
2008-05-07 Julien Chaffraix <firstname.lastname@example.com>
Reviewed by Adam Roben.
wx & Gtk build fix.
Add SIZE_MAX definition for the wx port.
- os-win32/stdint.h:
2008-05-07 Julien Chaffraix <email@example.com>
Reviewed by Adam Roben.
wx & Gtk build fix.
- platform/network/curl/FormDataStreamCurl.cpp: Added stdint.h include. We need to define STDC_LIMIT_MACROS to have SIZE_MAX exported.
- platform/network/curl/FormDataStreamCurl.h: Removed cstdint include (replaced by stdint.h) as it is not present on the build bots.
- plugins/gtk/PluginDatabaseGtk.cpp: Added missing #endif.
- 10:11 AM Changeset in webkit [32959] by
- 3 edits2 adds in trunk
Bug 18900: Password field has focus but can't type text (i.rememberthemilk.com)
Original patch by Aaron Golden and Tim Omernick. Reviewed by Adele.
Test: fast/forms/textfield-to-password-on-focus.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): If the current node has focus, call updateFocusAppearance() to make sure its state is correct after changing its type.
Bug 18900: Password field has focus but can't type text (i.rememberthemilk.com)
Reviewed by Adele.
- fast/forms/textfield-to-password-on-focus-expected.txt: Added.
- fast/forms/textfield-to-password-on-focus.html: Added.
- 9:35 AM Changeset in webkit [32958] by
- 6 edits in trunk/WebCore
<rdar://problem/4867889> REGRESSION: "Choose File.." buttons are exposed as AXGroup instead of AXButton
- 7:21 AM Changeset in webkit [32957] by
- 2 edits in trunk/LayoutTests
2008-05-07 Tor Arne Vestbø <firstname.lastname@example.com>
Reviewed by Simon
Add ~250 tests that fail to the skipped list so we have a sane baseline.
- 6:05 AM Changeset in webkit [32956] by
- 5 edits2 adds in trunk/WebCore
2008-05-07 Julien Chaffraix <email@example.com>
Reviewed by Eric.
Bug 17971: [Curl] FormData processing should be moved to its own class
Move FormData treatment into FormDataStream. The aim is to have FormDataStream behave like a stream that cURL
could manipulate.
First step into having complete file uploading facility in cURL.
No test case as it is only code refactoring.
- GNUmakefile.am: Add FormDataStreamCurl.cpp
- platform/network/ResourceHandleInternal.h: Move code to FormStreamDataCurl.h (WebCore::ResourceHandleInternal::ResourceHandleInternal):
- platform/network/curl/FormDataStreamCurl.cpp: Added. (WebCore::FormDataStream::~FormDataStream): (WebCore::FormDataStream::read):
- platform/network/curl/FormDataStreamCurl.h: Added. (WebCore::FormDataStream::FormDataStream):
- platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::readCallback): Move code to FormDataStreamCurl.cpp
- 5:28 AM Changeset in webkit [32955] by
- 2 edits in trunk/WebCore
2008-05-07 Adam Treat <firstname.lastname@example.com>
Reviewed by Simon.
Fixed wrong transform being used for creating the pixmap for a new
transparency layer. This fixes the popup menus on dell.com.
- 5:10 AM Changeset in webkit [32954] by
- 5 edits in trunk/WebCore
2008-05-07 Ariya Hidayat <email@example.com>
Reviewed by Simon.
Share the plug-in directories between Gtk and Qt/X11 port.
- platform/qt/FileSystemQt.cpp: (WebCore::homeDirectoryPath): Implement it for Qt.
- plugins/PluginDatabase.cpp: (WebCore::addMozillaPluginDirectories): Shared code. (WebCore::PluginDatabase::defaultPluginDirectories): (WebCore::PluginDatabase::isPreferredPluginDirectory): Shared code.
- plugins/gtk/PluginDatabaseGtk.cpp: (WebCore::PluginDatabase::isPreferredPluginDirectory): Refactored.
- plugins/qt/PluginDatabaseQt.cpp: Refactored.
- 4:46 AM Changeset in webkit [32953] by
- 3 edits in trunk/WebCore
2008-05-07 Tor Arne Vestbø <firstname.lastname@example.com>
Reviewed by Simon
Fix build issues on Mac and refeactor the .pro file a bit.
- 4:45 AM Changeset in webkit [32952] by
- 2 edits in trunk/WebCore
2008-05-07 Tor Arne Vestbø <firstname.lastname@example.com>
Reviewed by Simon
Draw scrollview corners (between scrollbars) using the Qt style.
- 2:50 AM Changeset in webkit [32951] by
- 2 edits in trunk/WebKitTools
Use File::Find and Getopt::Long in make-js-test-wrappers
Reviewed by Darin.
- Scripts/make-js-test-wrappers:
- Updated Apple copyright statement.
Added command-line switch parsing and -hhelp switch.
- Allowed user to pass list of files/directories on which to do a restricted search for TEMPLATE.html files. The default behavior is still to search the entire LayoutTests directory.
- Removed duplicate 'use strict' statement.
- Replaced use of
findstatements with File::Find::find().
- Remove unneeded chomp() calls now that we use File::Find. (directoryFilter): Added. Filters .svn directories when used with File::Find::find(). (findTemplateFiles): Added. Returns a list of TEMPLATE.html files found.
- 2:37 AM Changeset in webkit [32950] by
- 2 edits in trunk/WebCore
2008-05-07 Simon Hausmann <Simon Hausmann>
Fix the Qt build, added AccessibilityListBox and ListBoxOption.cpp to
the build.
- 2:37 AM Changeset in webkit [32949] by
- 2 edits in trunk/JavaScriptCore
2008-05-07 Ariya Hidayat <firstname.lastname@example.com>
Reviewed by Simon.
Support for isMainThread in the Qt port.
- wtf/ThreadingQt.cpp: (WTF::initializeThreading): Adjusted. (WTF::isMainThread): Added.
- 2:36 AM Changeset in webkit [32948] by
- 2 edits in trunk/WebCore
2008-05-07 Ariya Hidayat <firstname.lastname@example.com>
Rubber-stamped by Holger.
Fix building without storage support.
- page/PageGroup.cpp: (WebCore::PageGroup::closeLocalStorage): proper #if
- 2:36 AM Changeset in webkit [32947] by
- 2 edits in trunk/WebCore
2008-05-07 Ariya Hidayat <email@example.com>
Rubber-stamped by Oliver Hunt.
Fix building without accessibility.
- page/AXObjectCache.cpp: (WebCore::AXObjectCache::selectedChildrenChanged): proper #if
- 2:02 AM Changeset in webkit [32946] by
- 10 edits in branches/squirrelfish/JavaScriptCore
Partial fix for current performance regressions.
Patch from Cameron Zwarich
Reviewed by Oliver
Fix a performance regression caused by the introduction of property
attributes to SymbolTable in r32859 by encoding the attributes and the
register index into a single field of SymbolTableEntry.
This leaves Node::optimizeVariableAccess() definitely broken, although
it was probably not entirely correct in SquirrelFish before this change.
May 6, 2008:
- 11:33 PM Changeset in webkit [32945] by
- 3 edits4 adds in trunk
Reviewed by Darin Adler.
- fix <rdar://problem/5914544> Crash in layoutInlineChildren()
Test: fast/block/float/float-on-zero-height-line.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::markLinesDirtyInVerticalRange):
Reviewed by Darin Adler.
- test for <rdar://problem/5914544> Crash in layoutInlineChildren()
- fast/block/float/float-on-zero-height-line.html: Added.
- platform/mac/fast/block/float/float-on-zero-height-line-expected.checksum: Added.
- platform/mac/fast/block/float/float-on-zero-height-line-expected.png: Added.
- platform/mac/fast/block/float/float-on-zero-height-line-expected.txt: Added.
- 11:16 PM Changeset in webkit [32944] by
- 3 edits2 moves in trunk/WebKit
2008-05-06 Stephanie Lewis <firstname.lastname@example.com>
Reviewed by Andersca.
prepare for plugin fast teardown work - make WebPluginDatabase a objective C++ file.
- Plugins/WebPluginDatabase.m: Removed.
- Plugins/WebPluginDatabase.mm: Copied from WebKit/mac/Plugins/WebPluginDatabase.m.
- Plugins/npapi.m: Removed.
- Plugins/npapi.mm: Copied from WebKit/mac/Plugins/npapi.m.
prepare for plugin fast teardown work - make WebPluginDatabase a objective C++ file.
- WebKit.xcodeproj/project.pbxproj:
- 10:35 PM Changeset in webkit [32943] by
- 11 edits in trunk
2008-05-06 Alice Liu <firstname.lastname@example.com>
Reviewed by Adele Peterson and John Sullivan.
- WebCore.vcproj/WebCore.vcproj:
- page/AXObjectCache.cpp: (WebCore::AXObjectCache::selectedChildrenChanged):
- page/AccessibilityObject.h: (WebCore::AccessibilityObject::document): (WebCore::AccessibilityObject::topDocumentFrameView): (WebCore::AccessibilityObject::documentFrameView):
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::document): (WebCore::AccessibilityRenderObject::topDocumentFrameView): (WebCore::AccessibilityRenderObject::documentFrameView):
- page/AccessibilityRenderObject.h:
- page/mac/AXObjectCacheMac.mm:
- page/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper position]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
2008-05-06 Alice Liu <firstname.lastname@example.com>
Reviewed by Adele Peterson and John Sullivan.
- AccessibleBase.cpp: (AccessibleBase::get_accParent):
- AccessibleDocument.cpp: (AccessibleDocument::document):
- 10:31 PM Changeset in webkit [32942] by
- 5 edits in trunk/WebCore
2008-05-06 Brady Eidson <email@example.com>
Reviewed by Sam Weinig
Fix a few bugs with the final sync'ing of LocalStorageAreas when the thread is shut down.
1 - A sync task actually needs to be scheduled for each LocalStorageArea when the shut down occurs.
2 - Pending sync timers all need to be cancelled.
- storage/LocalStorage.cpp: (WebCore::LocalStorage::storageArea): (WebCore::LocalStorage::close): Tell each LocalStorageArea to schedule it's final sync before scheduling thread termination.
- storage/LocalStorage.h: Change the map to be of LocalStorageAreas instead of StorageAreas
- storage/LocalStorageArea.cpp: (WebCore::LocalStorageArea::LocalStorageArea): (WebCore::LocalStorageArea::~LocalStorageArea): ASSERT the timer has been cancelled, but make SURE it is in release builds. (WebCore::LocalStorageArea::scheduleFinalSync): Cancel the sync timer, schedule the final sync, and set the "final sync scheduled" flag (WebCore::LocalStorageArea::scheduleItemForSync): ASSERT that the final sync hasn't already been scheduled (WebCore::LocalStorageArea::scheduleClear): Ditto
- storage/LocalStorageArea.h:
- 9:42 PM Changeset in webkit [32941] by
- 2 edits in trunk/WebCore
wx build fix. Adding files added in r32925 to the bakefiles.
- 9:10 PM Changeset in webkit [32940] by
- 2 edits in branches/squirrelfish/JavaScriptCore
2008-05-06 Maciej Stachowiak <firstname.lastname@example.com>
Rubber stamped by Oliver.
- add missing ! in an assert that I failed to reverse
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::CodeGenerator):
- 9:01 PM Changeset in webkit [32939] by
- 282 edits in branches/squirrelfish/LayoutTests
2008-05-06 Geoffrey Garen <email@example.com>
Reviewed by Oliver Hunt.
To facilitate merging between the squirrelfish branch and trunk, I
edited a bunch of layout tests to make sure their results don't depend
on the exact text of an exception message generated by the JavaScript engine.
(We do want to test JavaScript exception messages -- we just don't want
to test them 300 times over, in tests that aren't supposed to be about
JavaScript at all.)
- I fixed bugs that were causing these tests to throw exceptions by accident, and updated results to reflect correct behavior:
- editing/selection/contenteditable-click-inside.html:
- platform/mac/editing/selection/contenteditable-click-inside-expected.checksum:
- platform/mac/editing/selection/contenteditable-click-inside-expected.png:
- platform/mac/editing/selection/contenteditable-click-inside-expected.txt:
- editing/selection/contenteditable-click-outside.html:
- platform/mac/editing/selection/contenteditable-click-outside-expected.checksum:
- platform/mac/editing/selection/contenteditable-click-outside-expected.png:
- platform/mac/editing/selection/contenteditable-click-outside-expected.txt:
- fast/forms/selected-index-assert.html:
- fast/forms/selected-index-assert-expected.txt:
- tables/mozilla_expected_failures/core/captions1.html:
- platform/mac/tables/mozilla_expected_failures/core/captions1-expected.txt:
- I changed these tests to explicitly throw/report exceptions, so their results don't depend on how the engine constructs messages for implicit exceptions:
- fast/xpath/nsresolver-exception.xhtml:
- fast/xpath/nsresolver-exception-expected.txt:
- platform/mac/fast/AppleScript/001.html:
- platform/mac/fast/AppleScript/001-expected.txt:
- dom/xhtml/level3/core/selfxhtml.js
- dom/xhtml/level3/core/*expected.txt (about 280 of these changed)
- 8:52 PM Changeset in webkit [32938] by
- 4 edits in branches/squirrelfish/JavaScriptCore
2008-05-06 Maciej Stachowiak <firstname.lastname@example.com>
Reviewed by Oliver.
- fixed "SQUIRRELFISH: window.this shows up as a property, but it shouldn't" https://bugs.webkit.org/show_bug.cgi?id=18868
The basic approach is to have "this" only be present in the symbol
table at compile time, not runtime.
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::~CodeGenerator): Remove "this" from symbol table. (KJS::CodeGenerator::CodeGenerator): Add "this" back when re-using a symbol table.
- VM/CodeGenerator.h:
- VM/Machine.cpp: (KJS::Machine::execute): Don't assert that "this" is in the symbol table.
- 8:36 PM Changeset in webkit [32937] by
- 12 edits in branches/squirrelfish/WebCore
Bug 18866: SQUIRRELFISH: JS/ObjC bridge is broken <https://bugs.webkit.org/show_bug.cgi?id=18866>
Bug 18867: SQUIRRELFISH: JS/NPRuntime bridge is broken <https://bugs.webkit.org/show_bug.cgi?id=18867>
Reviewed by Maciej
This fixes function binding logic for the ObjC and NPRuntime by
replacing incorrect implementations of implementsCall (which is
no longer virtual) with implementations of getCallData.
- 7:10 PM Changeset in webkit [32936] by
- 2 edits in trunk/WebCore
2008-05-06 Alp Toker <firstname.lastname@example.com>
GTK+ build fix. Add empty stub to keep non-accessible ports building.
- page/AXObjectCache.h: (WebCore::AXObjectCache::selectedChildrenChanged):
- 6:47 PM Changeset in webkit [32935] by
- 6 edits in trunk/WebCore
2008-05-06 Beth Dakin <email@example.com>
Reviewed by Darin.
Fix for <rdar://problem/5907916> Implement 'aria-labeledby' and
'aria-describedby' attributes.
- html/HTMLAttributeNames.in: Added new attributes. Added both the British spelling (since that is what is specified in the spec), and the American spelling (since the bug filer and I are two Americans who keep spelling it the American way by accident).
- page/AccessibilityObject.cpp: Added empty wrappers. These functions can't do anything meaningful without a renderer. (WebCore::AccessibilityObject::ariaAccessiblityName): (WebCore::AccessibilityObject::ariaLabeledByAttribute): (WebCore::AccessibilityObject::ariaDescribedByAttribute):
- page/AccessibilityObject.h:
Here is where the real work is done.
- page/AccessibilityRenderObject.h:
- page/AccessibilityRenderObject.cpp: (WebCore::accessibleNameForNode): Takes a node and finds its contribution to the accessible name, as defined by the Mozilla ARIA Implementer's Guide. (WebCore::AccessibilityRenderObject::ariaAccessiblityName): Takes a string of space-separated IDs, fetches the corresponding element for each ID, and concatenates an accessible name based on the elements. (WebCore::AccessibilityRenderObject::ariaLabeledByAttribute): Retrieve the labeledby attribute and send its contents to ariaAccessibilityName(). (WebCore::AccessibilityRenderObject::title): Return the ARIA labeledby value if one exists. (WebCore::AccessibilityRenderObject::ariaDescribedByAttribute): Retrieve the describedby attribute and send its contents to ariaAccessibilityName(). (WebCore::AccessibilityRenderObject::accessibilityDescription): Return the ARIA describedby attribute if one exists.
These are two bugs I spotted.
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored): Don't
ignore anything with an ARIA role.
(WebCore::AccessibilityRenderObject::roleValue): Button tags maps
to ButtonRole.
- 6:28 PM Changeset in webkit [32934] by
- 1 edit in trunk/WebCore/ChangeLog
Fix tyop
- 6:27 PM Changeset in webkit [32933] by
- 5 edits in trunk/WebCore
2008-05-06 Anders Carlsson <email@example.com>
Reviewed by Brady.
Support reading back app caches from the datbase.
- loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::ApplicationCache): Initialize m_storageID to 0.
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::cacheDestroyed): If the cache being destroyed is not the newest cache, it should no longer be stored in the database. Remove it.
Don't store the cache here.
Store it here instead.
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::loadCacheGroup): New method that loads a cache group with a given manifest URL (or returns 0 if the load fails).
Search for the group in the database.
New method that loads the host hashes from the database.
Search in the database for a cache that contains the resource.
New method that loads a cache with a given ID.
New method that removes a cache.
- loader/appcache/ApplicationCacheStorage.h: Add definitions.
- 6:21 PM Changeset in webkit [32932] by
- 3 edits in trunk/WebCore
2008-05-06 Alp Toker <email@example.com>
Partial GTK+ build fix. Add files from r32925 to the build and replace
'nil' return with 0.
- GNUmakefile.am:
- page/AccessibilityListBoxOption.cpp: (WebCore::AccessibilityListBoxOption::parentObject):
- 5:52 PM Changeset in webkit [32931] by
- 3 edits2 adds in trunk/WebKitExamplePlugins
2008-05-06 Anders Carlsson <email@example.com>
Reviewed by Mitz.
Add NPN_PopUpContextMenu example.
- NetscapeCocoaPlugin/MenuHandler.h: Added.
- NetscapeCocoaPlugin/MenuHandler.m: Added. (-[MenuHandler _openURL:]): (-[MenuHandler _disabledItem:]): (-[MenuHandler validateUserInterfaceItem:]): (-[MenuHandler initWithBrowserFuncs:instance:]): (-[MenuHandler dealloc]): (-[MenuHandler menu]):
- NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj/project.pbxproj:
- NetscapeCocoaPlugin/main.m: (NPP_Destroy): (handleMouseEvent):
- 5:32 PM Changeset in webkit [32930] by
- 3 edits in trunk/WebCore
2008-05-06 Brady Eidson <email@example.com>
Reviewed by Anders
Make LocalStorage persistent using a SQLite database.
There's a few things going on here. Whenever an item is changed, we add it to a set of
"items to be sync'ed." Instead of immediately scheduling the sync'ing on the background
thread, we set a "sync timer" instead. This is to shield against a series of rapid changes
to avoid thread churn.
When the sync timer fires, we move the "items to be sync'ed" set to a background thread set
and schedule the sync task which is where the items are actually committed to disk.
Current design for reading items back in from disk is to be as aggressive as possible.
When a page first accesses it's LocalStorage area, we begin to import all items in from disk so
they are immediately available. A future enhancement will be to being this pre-fetching the
moment we start loading a page when we know that page has LocalStorage.
- storage/LocalStorageArea.cpp: (WebCore::LocalStorageArea::LocalStorageArea): (WebCore::LocalStorageArea::length): Return the length, or wait for the import to complete then return it. (WebCore::LocalStorageArea::key): Return the key, or wait for the import to complete then return it. (WebCore::LocalStorageArea::getItem): Return the item, or wait for the import to complete then return it. (WebCore::LocalStorageArea::setItem): Set the item, or hold the import lock and set it. The second case is because if the item is set while the import is still in progress, the new value should override whatever the imported value is. (WebCore::LocalStorageArea::removeItem): Remove the item, or hold the import lock and remove it. See the explanation for setItem() (WebCore::LocalStorageArea::contains): Return whether or not the item is contained. Do the same dance with the import flag, import lock, and import condition that the above methods do.
(WebCore::LocalStorageArea::itemChanged): Schedule the item for sync'ing
(WebCore::LocalStorageArea::itemRemoved): Schedule the removal of the item for sync'ing
(WebCore::LocalStorageArea::areaCleared): Schedule the clear for sync'ing, and clear all previously
scheduled items.
(WebCore::LocalStorageArea::scheduleItemForSync): Add an item to the sync set.
(WebCore::LocalStorageArea::scheduleClear): Set a bool flag denoting "All items removed." If any
items are later set before the actual removal takes place, they will be written *after* the removal.
(WebCore::LocalStorageArea::syncTimerFired): Move the current sync-set to the background thread sync set, then
schedule a sync task. Also transfer the "items cleared" flag to the "background thread items cleared" flag
(WebCore::LocalStorageArea::performImport): Import all items from disk, then signal the import complete.
(WebCore::LocalStorageArea::markImported): Set the imported flag and signal the import complete
(WebCore::LocalStorageArea::performSync): If the clear flag is set then drop all items. Then update or delete
each item waiting to be sync'ed
- storage/LocalStorageArea.h:
- 4:42 PM Changeset in webkit [32929] by
- 2 edits in trunk/WebCore
2008-05-06 Brady Eidson <firstname.lastname@example.com>
Rubberstamped by Mitz Pettel RTL
- storage/LocalStorage.cpp: (WebCore::LocalStorage::fullDatabaseFilename): Filename extensions for localstorage = all lowercase
- 4:32 PM Changeset in webkit [32928] by
- 3 edits in trunk/WebCore
2008-05-06 Brady Eidson <firstname.lastname@example.com>
Reviewed by Darin, Sam Weinig, and Anders
Preparation for upcoming work making LocalStorage persistent.
The final step before code that actually does storage and retrieval of LocalStorage items.
The LocalStorage set is responsible for controlling the path and filenames that individual
LocalStorageAreas will use for their persistent store. This adds the ability to return that
Also, add the scheduling methods that LocalStorageArea will use for importing and syncing
it's persistent items.
- storage/LocalStorage.cpp: (WebCore::LocalStorage::storageArea): Add some comments re: the future direction of this method once we actually do quota tracking. (WebCore::LocalStorage::fullDatabaseFilename): (WebCore::LocalStorage::scheduleImport): (WebCore::LocalStorage::scheduleSync):
- storage/LocalStorage.h:
- 4:27 PM Changeset in webkit [32927] by
- 14 edits4 adds in trunk/WebCore
rdar://problem/5408464> REGRESSION: Unable to use Voiceover on combo boxes (disneyjobs.com)
- 3:44 PM Changeset in webkit [32926] by
- 3 edits in trunk/WebCore
<rdar://problem/5455287> AXWebArea should include AXURL
Now it does
- 3:17 PM Changeset in webkit [32925] by
- 5 edits in trunk/WebCore
2008-05-06 Alice Liu <firstname.lastname@example.com>
Rubber-stamped by Beth
stab-in-the-dark attempt at fixing non-mac builds.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCoreSources.bkl:
- 3:16 PM Changeset in webkit [32924] by
- 4 edits in trunk/WebCore/loader/appcache
Whoops, I did not intend to commit this right now.
- 3:15 PM Changeset in webkit [32923] by
- 6 edits in trunk/WebCore
2008-05-06 Anders Carlsson <email@example.com>
Reviewed by Adam.
Only use the toplevel application cache when loading subframes.
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::load):
- 3:00 PM Changeset in webkit [32922] by
- 27 edits3 adds in trunk
2008-05-06 Adam Barth <firstname.lastname@example.com>
Reviewed by Sam Weinig.
Implement asynchronous postMessage.
MessageEvent no longer bubbles as per r1237 in the HTML 5 working draft.
Collin Jackson <email@example.com> also contributed to this patch.
Test: http/tests/security/postMessage/delivery-order.html
- dom/MessageEvent.cpp: (WebCore::MessageEvent::MessageEvent):
- page/DOMWindow.cpp: (WebCore::PostMessageTimer::PostMessageTimer): (WebCore::PostMessageTimer::event): (WebCore::PostMessageTimer::targetOrigin): (WebCore::PostMessageTimer::fired): (WebCore::DOMWindow::postMessage): (WebCore::DOMWindow::postMessageTimerFired):
- page/DOMWindow.h:
- page/DOMWindow.idl:
2008-05-06 Adam Barth <email@example.com>
Reviewed by Sam Weinig.
Update tests for asynchronous postMessage.
Collin Jackson <email@example.com> also contributed to this patch.
- http/tests/messaging/cross-domain-message-send.html:
- http/tests/messaging/resources/cross-domain-message-receive.html:
- http/tests/security/cross-frame-access-delete.html:
- http/tests/security/cross-frame-access-history-put.html:
- http/tests/security/cross-frame-access-location-put.html:
- http/tests/security/postMessage/delivery-order-expected.txt: Added.
- http/tests/security/postMessage/delivery-order.html: Added.
- http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt:
- http/tests/security/postMessage/invalid-origin-throws-exception.html:
- http/tests/security/postMessage/origin-unaffected-by-base-tag-expected.txt:
- http/tests/security/postMessage/origin-unaffected-by-base-tag.html:
- http/tests/security/postMessage/origin-unaffected-by-document-domain-expected.txt:
- http/tests/security/postMessage/origin-unaffected-by-document-domain.html:
- http/tests/security/postMessage/resources/javascript-post-message-sender.html:
- http/tests/security/postMessage/resources/post-message-listener.html:
- http/tests/security/postMessage/resources/recv.js: Added.
- http/tests/security/postMessage/target-origin-expected.txt:
- http/tests/security/postMessage/target-origin.html:
- http/tests/security/resources/cross-frame-iframe-for-delete-test.html:
- http/tests/security/resources/cross-frame-iframe-for-history-put-test.html:
- http/tests/security/resources/cross-frame-iframe-for-location-put-test.html:
- http/tests/security/resources/xss-eval3.html:
- http/tests/security/xss-eval.html:
- 2:31 PM Changeset in webkit [32921] by
- 8 edits in branches/squirrelfish/JavaScriptCore
2008-05-06 Geoffrey Garen <firstname.lastname@example.com>
Reviewed by Oliver Hunt.
Trivial support for function.arguments: Currently, we only support
function.arguments from within the scope of function.
This fixes the remaining Mozilla JS test failures.
SunSpider reports no change.
- JavaScriptCore.exp:
- VM/Machine.cpp: (KJS::Machine::privateExecute): Separated scope chain deref from activation register copying: since it is now possible for client code to create an activation on behalf of a function that otherwise wouldn't need one, having an activation no longer necessarily means that you need to deref the scope chain.
(KJS::Machine::getCallFrame): For now, this function only examines the
current scope. Walking parent scopes requires some refactoring in the
way we track execution stacks.
- kjs/ExecState.cpp: (KJS::ExecState::ExecState): We use a negative call frame offset to indicate that a given scope is not a function call scope.
- 2:01 PM Changeset in webkit [32920] by
- 10 edits in trunk/WebCore
2008-05-06 Anders Carlsson <firstname.lastname@example.com>
Reviewed by Brady.
Store cache to the database.
- loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::addResource): If the cache has been saved to disk, save the resource as well.
- loader/appcache/ApplicationCache.h: (WebCore::ApplicationCache::onlineWhitelist): New method which returns the online whitelist.
Setter/getter for the application cache storage ID.
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): Save the cache/group to disk.
- loader/appcache/ApplicationCacheGroup.h: (WebCore::ApplicationCacheGroup::setStorageID): (WebCore::ApplicationCacheGroup::storageID): Setter/getter for the application cache group storage ID.
- loader/appcache/ApplicationCacheResource.cpp: (WebCore::ApplicationCacheResource::addType): We can't add a new type if the resource has been saved to disk.
- loader/appcache/ApplicationCacheResource.h: (WebCore::ApplicationCacheResource::setStorageID): (WebCore::ApplicationCacheResource::storageID): Setter/getter for the application cache resource storage ID.
- loader/appcache/ApplicationCacheStorage.cpp:
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::executeSQLCommand): New method for executing SQL and logging any errors.
Create new tables.
New method for executing an SQL statement and logging any errors.
New methods for storing a cache group, cache and cache resource to the store.
New method which stores the newest cache and updates the newest cache field in the cache group.
- loader/appcache/ApplicationCacheStorage.h: Add new methods.
- platform/sql/SQLiteStatement.h: (WebCore::SQLiteStatement::query): Getter for the SQL query.
- 1:47 PM Changeset in webkit [32919] by
- 2 edits in trunk/WebKit/mac
2008-05-06 Anders Carlsson <firstname.lastname@example.com>
Reviewed by Darin.
Initialize numArchs to 0.
- Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage isNativeLibraryData:]):
- 1:46 PM Changeset in webkit [32918] by
- 10 edits4 adds in trunk/WebCore
2008-05-06 Brady Eidson <firstname.lastname@example.com>
Reviewed by Darin Adler
Preparation for upcoming work making LocalStorage persistent.
Writing persistent values for LocalStorage will take place on a background thread.
Here is that background thread, as well as most of the hooks that will be utilized to
make the whole song and dance work.
The thread itself is very simple and MessageQueue based. LocalStorageTasks are what
mark the work that needs to be done and come in 5 flavors: Import and Sync a LocalStorage set,
Import and Sync a LocalStorageArea, and terminate the thread.
This patch accomplished 2 things:
1 - Each PageGroup has its own LocalStorage set. Upon its creation its LocalStorageThread is
created and started.
2 - At application shutdown, each thread is synchronously terminated.
What happens between steps 1 and 2 will come later.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- storage/LocalStorage.cpp: Add some threading ASSERTs to make it clear which thread each method is meant to be called from. (WebCore::LocalStorage::LocalStorage): (WebCore::LocalStorage::storageArea): (WebCore::LocalStorage::performImport): Placeholder for importing known origins and quotas (WebCore::LocalStorage::performSync): Placeholder for writing out updated origins and quotas (WebCore::LocalStorage::close): Synchronously terminate the thread.
- storage/LocalStorage.h:
- storage/LocalStorageArea.cpp: Add some threading ASSERTs to make it clear which thread each method is meant to be called from. (WebCore::LocalStorageArea::itemChanged): (WebCore::LocalStorageArea::itemRemoved): (WebCore::LocalStorageArea::areaCleared): (WebCore::LocalStorageArea::dispatchStorageEvent): (WebCore::LocalStorageArea::performImport): Placeholder for importing all items for this LocalStorageArea to prime the page before the items are needed (WebCore::LocalStorageArea::performSync): Placeholder for writing out dirty items to disk
- storage/LocalStorageArea.h:
- storage/LocalStorageTask.cpp: Added. (WebCore::LocalStorageTask::LocalStorageTask): (WebCore::LocalStorageTask::performTask):
- storage/LocalStorageTask.h: Added. (WebCore::LocalStorageTask::): (WebCore::LocalStorageTask::createImport): (WebCore::LocalStorageTask::createSync): (WebCore::LocalStorageTask::createTerminate):
- storage/LocalStorageThread.cpp: Added. (WebCore::LocalStorageThread::create): (WebCore::LocalStorageThread::LocalStorageThread): (WebCore::LocalStorageThread::start): (WebCore::LocalStorageThread::localStorageThreadStart): (WebCore::LocalStorageThread::localStorageThread): (WebCore::LocalStorageThread::scheduleImport): (WebCore::LocalStorageThread::scheduleSync): (WebCore::LocalStorageThread::terminate): (WebCore::LocalStorageThread::performTerminate):
- storage/LocalStorageThread.h: Added.
- 1:40 PM Changeset in webkit [32917] by
- 5 edits in trunk/WebKit/mac
2008-05-06 Anders Carlsson <email@example.com>
Reviewed by Darin.
Add implementation of NPN_PopUpContextMenu.
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView popUpContextMenu:]):
- Plugins/WebBaseNetscapePluginViewPrivate.h:
- Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):
- Plugins/npapi.m: (NPN_PopUpContextMenu):
- 1:40 PM Changeset in webkit [32916] by
- 3 edits in trunk/WebCore
2008-05-06 Anders Carlsson <email@example.com>
Reviewed by Darin.
Add NPN_PopUpContextMenu.
- bridge/npapi.h:
- plugins/npfunctions.h:
- 1:35 PM Changeset in webkit [32915] by
- 1 edit in trunk/WebCore/ChangeLog
2008-05-06 Alp Toker <email@example.com>
GTK+ build fix. Add file from r32911 to the build.
- GNUmakefile.am:
- 1:21 PM Changeset in webkit [32914] by
- 4 edits in trunk/WebKit/gtk
Rubber stamped by Alp.
Back out 17626. It wasn't ready for commit.
- 1:17 PM Changeset in webkit [32913] by
- 2 edits in trunk/WebCore
2008-05-06 Gwenole Beauchesne <email@example.com>
Reviewed by Alp Toker.
[GTK] Fix varargs terminator in g_build_filename()
- plugins/gtk/PluginDatabaseGtk.cpp: (WebCore::PluginDatabase::isPreferredPluginDirectory): Fix varargs terminator.
- 11:44 AM Changeset in webkit [32912] by
- 2 edits in trunk/WebCore
2008-05-06 Kevin McCullough <email@example.com>
- Forgot to update localized Strings from previous checkin.
- English.lproj/localizedStrings.js:
- 11:39 AM Changeset in webkit [32911] by
- 8 edits2 adds in trunk/WebCore
<rdar://problem/5408464> REGRESSION: Unable to use Voiceover on combo boxes (disneyjobs.com)
<rdar://problem/5895634> AX: AccessibilityObjectWrapper is being leaked all over the place
<rdar://problem/5893907> CrashTracer: [REGRESSION] 44 crashes in Safari at com.apple.WebCore: WebCore::AccessibilityObject::clearChildren + 9
Initial prep work to support accessibility objects that do not have renderers.
- 11:16 AM Changeset in webkit [32910] by
- 2 edits in trunk/WebKit/mac
2008-05-06 Anders Carlsson <email@example.com>
Fix typo (don't read random memory).
- Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage isNativeLibraryData:]):
- 10:55 AM Changeset in webkit [32909] by
- 3 edits in trunk/WebKit
2008-05-05 Anders Carlsson <firstname.lastname@example.com>
Reviewed by Darin.
Change the isNativeLibraryData: method to handle universal binaries.
- Plugins/WebBasePluginPackage.m: (swapIntsInHeader): (-[WebBasePluginPackage isNativeLibraryData:]):
- 10:54 AM Changeset in webkit [32908] by
- 10 adds in trunk/WebKitExamplePlugins
Reviewed by Jon, Tim and Mark.
Add a sample NPAPI plugin that uses the Cocoa event model.
- .: Added.
- ChangeLog: Added.
- NetscapeCocoaPlugin: Added.
- NetscapeCocoaPlugin/English.lproj: Added.
- NetscapeCocoaPlugin/English.lproj/InfoPlist.strings: Added.
- NetscapeCocoaPlugin/Info.plist: Added.
- NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj: Added.
- NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj/project.pbxproj: Added.
- NetscapeCocoaPlugin/main.m: Added. (NP_Initialize): (NP_GetEntryPoints): (NP_Shutdown): (NPP_New): (NPP_Destroy): (NPP_SetWindow): (NPP_NewStream): (NPP_DestroyStream): (NPP_WriteReady): (NPP_Write): (NPP_StreamAsFile): (NPP_Print): (handleDraw): (eventType): (invalidatePlugin): (handleMouseEvent): (handleKeyboardEvent): (NPP_HandleEvent): (NPP_URLNotify): (NPP_GetValue): (NPP_SetValue):
- NetscapeCocoaPlugin/test.html: Added.
- 10:32 AM Changeset in webkit [32907] by
- 2 edits in trunk/WebCore
Reviewed by Rob Buis.
Prevented SVGRootInlineBox from static_casting a
node to a class it doesn't inherit
- 10:28 AM Changeset in webkit [32906] by
- 10 edits in trunk
2008-05-06 Brady Eidson <firstname.lastname@example.com>
Reviewed by Darin Adler
Preparation for upcoming work making LocalStorage persistent.
When the application terminates, all pending local storage writes need to be
sync'ed out to disk.
This works n combination with platform specific code in WebKit that calls it.
- WebCore.base.exp:
- page/PageGroup.cpp: (WebCore::PageGroup::closeLocalStorage): Close all open LocalStorage objects
- page/PageGroup.h:
- storage/LocalStorage.cpp: (WebCore::LocalStorage::close): Placeholder for what will sync and terminate the local storage thread in the future.
- storage/LocalStorage.h:
2008-05-06 Brady Eidson <email@example.com>
Reviewed by Darin Adler
Preparation for upcoming work making LocalStorage persistent.
When the application terminates, all LocalStorage areas must be sync'ed out to disk first.
- WebView/WebView.mm: (+[WebView _applicationWillTerminate]): Close all LocalStorage areas before quitting.
2008-05-06 Brady Eidson <email@example.com>
Reviewed by Darin Adler
Preparation for upcoming work making LocalStorage persistent.
When the application terminates, all LocalStorage areas must be sync'ed out to disk first.
- WebKitDLL.cpp: (shutDownWebKit): Close all LocalStorage areas before quitting.
- 10:24 AM Changeset in webkit [32905] by
- 2 edits in trunk/WebCore
2008-05-06 Brady Eidson <firstname.lastname@example.com>
Rubberstamped by David Kilzer
- WebCore.base.exp: Sort this mess!
- 10:07 AM Changeset in webkit [32904] by
- 6 edits in trunk/WebKit/win
2008-05-05 Anders Carlsson <email@example.com>
Reviewed by John.
Add preference for enabling the offline web application cache.
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::setOfflineWebApplicationCacheEnabled): (WebPreferences::offlineWebApplicationCacheEnabled):
- WebPreferences.h:
- WebView.cpp: (WebView::notifyPreferencesChanged):
- 9:46 AM SquirrelFish edited by
- (diff)
- 9:43 AM SquirrelFish edited by
- (diff)
- 7:21 AM Changeset in webkit [32903] by
- 1 edit in trunk/LayoutTests/editing/inserting/edited-whitespace-1.html
Landing an updated test that was supposed to be part of r32879.
- 6:12 AM Changeset in webkit [32902] by
- 2 edits in trunk/WebKit/qt
2008-05-06 Simon Hausmann <Simon Hausmann>
Reviewed by Holger.
Fix logic error in QWebHitTestResult::isNull().
May 5, 2008:
- 11:29 PM SquirrelFish edited by
- (diff)
- 10:01 PM Changeset in webkit [32901] by
- 2 edits in trunk/WebCore
Fix 60 crashes seen on the buildbots that were misreported as hangs.
Reviewed by Dan Bernstein.
- dom/Document.cpp:
(WebCore::Document::detachNodeIterator): Null-check page() before dereferencing it.
(WebCore::Document::nodeWillBeRemoved): Ditto.
(WebCore::Document::textInserted): Ditto.
(WebCore::Document::textNodesMerged): Ditto.
(WebCore::Document::textRemoved): Ditto.
- 9:09 PM Changeset in webkit [32900] by
- 3 edits in trunk/WebCore
2008-05-05 Brady Eidson <email@example.com>
Reviewed by Mitz Pettel RTL
Preparation for upcoming work making LocalStorage persistent.
The other half of the StorageMap::importItem() addition.
- storage/StorageArea.cpp: (WebCore::StorageArea::importItem):
- storage/StorageArea.h:
- 9:03 PM Changeset in webkit [32899] by
- 5 edits in trunk/WebCore
2008-05-05 Brady Eidson <firstname.lastname@example.com>
Reviewed by Mitz Pettel RTL
Preparation for upcoming work making LocalStorage persistent.
- Create the LocalStorage object for a PageGroup the moment the first Page is added to it The Settings of the first Page define what persistent path the LocalStorage will use
- Add a Frame argument for the LocalStorageArea request - this will allow a client object to be queried before the LocalStorageArea is established
- page/DOMWindow.cpp: (WebCore::DOMWindow::localStorage):
- page/PageGroup.cpp: (WebCore::PageGroup::addPage): (WebCore::PageGroup::localStorage):
- storage/LocalStorage.cpp: (WebCore::LocalStorage::LocalStorage): Take the path as a constructor argument. Deep copy the path as it will be used from another thread. (WebCore::LocalStorage::storageArea):
- storage/LocalStorage.h: (WebCore::LocalStorage::create):
- 8:16 PM Changeset in webkit [32898] by
- 2 edits in branches/squirrelfish/JavaScriptCore
Fix call frame set up for native -> JS function calls.
Review by Geoff
- 8:14 PM Changeset in webkit [32897] by
- 3 edits in trunk/WebCore
2008-05-05 Brady Eidson <email@example.com>
Reviewed by Mitz Pettel RTL
Preparation for upcoming work making LocalStorage persistent.
StorageMaps normally have copy-on-write semantics to help support SessionStorage.
For LocalStorage, we never want this behavior. When we forcefully import items into
a StorageMap from the LocalStorage background thread, this new import method will be used.
- storage/StorageMap.cpp: (WebCore::StorageMap::importItem): Add a deep-copy of the item to the map without worrying about copy-on-write.
- storage/StorageMap.h:
- 7:24 PM Changeset in webkit [32896] by
- 8 edits2 adds in branches/squirrelfish
2008-05-05 Geoffrey Garen <email@example.com>
Reviewed by Maciej Stachowiak.
Fixed ecma_3/Object/188.8.131.52-001.js, and similar bugs.
SunSpider reports a .4% speedup. Not sure what that's about.
- VM/Machine.cpp: (KJS::Machine::privateExecute): Check for exception return from equal, since toPrimitive can throw.
- kjs/operations.cpp: (KJS::strictEqual): In response to an error I made in an earlier version of this patch, I changed strictEqual to make clear the fact that it performs no conversions and can't throw, making it slightly more efficient in the process.
2008-05-05 Geoffrey Garen <email@example.com>
Reviewed by Maciej Stachowiak.
Layout test for exceptions thrown from equality comparisons.
- fast/js/exception-thrown-from-equal-expected.txt: Added.
- fast/js/exception-thrown-from-equal.html: Added.
- 5:45 PM Changeset in webkit [32895] by
- 3 edits in trunk/WebKitTools
Copy dependencies of ImageDiff, DumpRenderTree in post-build step.
- DumpRenderTree/win/DumpRenderTree.vcproj:
- DumpRenderTree/win/ImageDiff.vcproj:
- 5:23 PM Changeset in webkit [32894] by
- 2 edits in tags/Safari-6526.3.4/WebCore
Merged r32711.
- 5:21 PM Changeset in webkit [32893] by
- 5 edits in tags/Safari-6526.3.4
Merged r32699, 32701, 32702, 32704.
- 5:15 PM Changeset in webkit [32892] by
- 2 edits in tags/Safari-6526.3.4/WebKit/win
Merged r32698.
- 5:08 PM Changeset in webkit [32891] by
- 2 edits in tags/Safari-6526.3.4/WebCore
Merged r32659.
- 5:01 PM Changeset in webkit [32890] by
- 4 edits6 adds in trunk/WebCore
2008-05-05 Kevin McCullough <firstname.lastname@example.com>
Reviewed by Tim.
-<rdar://problem/5770054> JavaScript profiler (10928)
-Begininings of a UI for the Profiler in the WebInspector.
- English.lproj/InspectorLocalizedStrings.js: Add new strings to be localized.
- page/inspector/DatabasesPanel.js: Changed the name of the Databae's results table to be more generic as it is now also used by the profiler.
- page/inspector/Images/glossySelected.png: Added.
- page/inspector/Images/profilesIcon.png: Added.
- page/inspector/Images/treeUpTriangleBlack.png: Added.
- page/inspector/Images/treeUpTriangleWhite.png: Added.
- page/inspector/ProfileView.js: Added. Sets up the header of the table.
- page/inspector/ProfilesPanel.js: Added.
- page/inspector/ProfilesPanel.js: Added. Sets up the containers of the profiler's content.
- page/inspector/inspector.css: Change database-result-table to be more generic as well as add the styles needed by the profiler.
- page/inspector/inspector.html: Add profiler support.
- 4:42 PM Changeset in webkit [32889] by
- 2 edits in trunk/WebCore
2008-05-05 Brady Eidson <firstname.lastname@example.com>
Change by Darin, reviewed by Brady
Small efficiency improvement Darin just spotted
- storage/StorageMap.cpp: (WebCore::StorageMap::setItem):
- 4:41 PM Changeset in webkit [32888] by
- 3 edits in tags/Safari-6526.3.4/WebCore
- 4:31 PM Changeset in webkit [32887] by
- 2 edits in trunk/WebCore
2008-05-05 Antti Koivisto <email@example.com>
Reviewed by Anders.
Fix https://bugs.webkit.org/show_bug.cgi?id=18899
Bug 18899: REGRESSION (r32871): Non-Safari crash in WTF::HashTable on startup
- loader/loader.cpp: (WebCore::Loader::Loader):
- 4:04 PM Changeset in webkit [32886] by
- 2 edits in trunk/WebKit/mac
2008-05-05 Sam Weinig <firstname.lastname@example.com>
Reviewed by Darin Adler.
Fix for <rdar://problem/5884383>
Escape look-a-like characters from the the entire url.
- Misc/WebNSURLExtras.mm: (escapeUnsafeCharacters): (-[NSURL _web_userVisibleString]):
- 4:00 PM Changeset in webkit [32885] by
- 1 copy in tags/Safari-6526.3.4
New tag.
- 3:57 PM Changeset in webkit [32884] by
- 2 edits in trunk/WebCore
2008-05-05 Brady Eidson <firstname.lastname@example.com>
Reviewed by Sam Weinig
Fix a bug in StorageMap iterator tracking where the iterator was not successfully
invalidated at an appropriate time.
- storage/StorageMap.cpp: (WebCore::StorageMap::setItem): ALWAYS invalidate it here
- 3:50 PM Changeset in webkit [32883] by
- 7 edits in trunk
2008-05-05 Justin Garcia <firstname.lastname@example.com>
Reviewed by Darin.
<rdar://problem/5865171> REGRESSION: Creating a new quote places caret at beginning of quote instead of the end
Disable Range mutation on document modifications in Tiger and Leopard Mail,
since they do their own mutation which interferes with ours.
- WebCore.base.exp:
- dom/Document.cpp: (WebCore::Document::nodeChildrenChanged): (WebCore::Document::nodeWillBeRemoved): (WebCore::Document::textInserted): (WebCore::Document::textRemoved): (WebCore::Document::textNodesMerged): (WebCore::Document::textNodeSplit):
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::disableRangeMutationForOldAppleMail):
- page/Settings.h: (WebCore::Settings::rangeMutationDisabledForOldAppleMail):
2008-05-05 Justin Garcia <email@example.com>
Reviewed by Darin.
<rdar://problem/5865171> REGRESSION: Creating a new quote places caret at beginning of quote instead of the end
- WebView/WebView.mm: (-[WebView _updateSettingsFromPreferences:]): Disable Range mutation on changes to the document for Tiger and Leopard Mail. There is code in Mail that does it, and the two interfere.
- 3:47 PM Changeset in webkit [32882] by
- 8 edits1 add1 delete in trunk
2008-05-05 Sam Weinig <firstname.lastname@example.com>
Reviewed by Tim Hatcher.
Make the Inspector's localizable strings file match the format used by Dashboard widgets.
- English.lproj/InspectorLocalizedStrings.js: Removed.
- English.lproj/localizedStrings.js: Added.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- page/inspector/inspector.js:
2008-05-05 Sam Weinig <firstname.lastname@example.com>
Reviewed by Tim Hatcher.
Make the Inspector's localizable strings file match the format used by Dashboard widgets.
- WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::localizedStringsURL):
2008-05-05 Sam Weinig <email@example.com>
Reviewed by Tim Hatcher.
Make the Inspector's localizable strings file match the format used by Dashboard widgets.
- WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::localizedStringsURL):
- 1:51 PM Changeset in webkit [32881] by
- 18 edits in trunk
2008-05-05 Steve Falkenburg <firstname.lastname@example.com>
Add WebPreference for application chrome mode.
Reviewed by Dave Hyatt.
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::inApplicationChromeMode): (WebPreferences::setApplicationChromeMode):
- WebPreferences.h:
- WebView.cpp: (WebView::notifyPreferencesChanged):
2008-05-05 Steve Falkenburg <firstname.lastname@example.com>
Add support for default button appearance.
Add WebCore setting for app chrome mode.
Reviewed by Dave Hyatt.
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSValueKeywords.in: Added default-button value keyword.
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setApplicationChromeMode):
- page/Settings.h: (WebCore::Settings::inApplicationChromeMode):
- rendering/RenderButton.cpp: (WebCore::RenderButton::RenderButton): (WebCore::RenderButton::setStyle): (WebCore::RenderButton::timerFired):
- rendering/RenderButton.h:
- rendering/RenderStyle.h: (WebCore::):
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorderOnly): (WebCore::RenderTheme::paintDecorations): (WebCore::RenderTheme::isControlStyled): (WebCore::RenderTheme::isDefault):
- rendering/RenderTheme.h: (WebCore::):
- rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::determineState): (WebCore::RenderThemeSafari::adjustRepaintRect): (WebCore::RenderThemeSafari::adjustButtonStyle):
- rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::supportsFocus):
- 1:35 PM Changeset in webkit [32880] by
- 2 edits in trunk/WebKitTools
2008-05-05 Adele Peterson <firstname.lastname@example.com>
Reviewed by Adam.
Look for the right ImageDiff executable for debug builds.
- Scripts/run-webkit-tests:
- 11:29 AM Changeset in webkit [32879] by
- 3 edits4 adds in trunk
Reviewed by Darin.
nbsps should be converted to entities in innerHTML
replacing with spaces using regexp creates inconsistent result
Tests: fast/dom/innerHTML-nbsp.html
- editing/markup.cpp: (WebCore::appendAttributeValue): (WebCore::escapeContentText): (WebCore::appendEscapedContent): Added U+00a0/nbsp to the list of characters to escape.
- 11:26 AM Changeset in webkit [32878] by
- 3 edits3 adds in trunk
2008-05-05 David Hyatt <firstname.lastname@example.com>
Fix for https://bugs.webkit.org/show_bug.cgi?id=18821. Fix some bugs in both get/PutImageData of <canvas>.
Reviewed by Eric
New tests added in fast/canvas/
- platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::getImageData): (WebCore::ImageBuffer::putImageData):
2008-05-05 David Hyatt <email@example.com>
Fix for https://bugs.webkit.org/show_bug.cgi?id=18821, putImageData incorrect when data has alpha.
Reviewed by Eric
- fast/canvas/canvas-alphaImageData-behavior-expected.txt: Added.
- fast/canvas/canvas-alphaImageData-behavior.html: Added.
- fast/canvas/canvas-alphaImageData-behavior.js: Added.
- 9:59 AM Changeset in webkit [32877] by
- 2 edits in trunk/JavaScriptCore
2008-05-05 Darin Adler <email@example.com>
Reviewed by John Sullivan.
- fix debug-only leak seen on buildbot
- wtf/HashTable.h: (WTF::HashTable::checkKey): After writing an empty value in, but before constructing a deleted value on top of it, call the destructor so the empty value doesn't leak.
- 9:47 AM Changeset in webkit [32876] by
- 3 edits in trunk/WebKit/mac
2008-05-05 Anders Carlsson <firstname.lastname@example.com>
Reviewed by Jess.
Apparently preflighting can cause hangs for some reason. Revert this for now.
- Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage _initWithPath:]):
- Plugins/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]):
- 9:44 AM Changeset in webkit [32875] by
- 2 edits in trunk/WebKitTools
2008-05-05 Darin Adler <firstname.lastname@example.com>
- Scripts/run-webkit-tests: Ignore a Java leak showing up in the WebKit leak tests.
- 9:34 AM Changeset in webkit [32874] by
- 2 edits in trunk/WebKit/mac
2008-05-05 Darin Adler <email@example.com>
Reviewed by Mitz.
- https://bugs.webkit.org/show_bug.cgi?id=18789 fix some shouldCloseWithWindow edge cases
- WebView/WebView.mm: (-[WebView viewWillMoveToWindow:]): Fix bug where we would stop observing the NSWindowWillCloseNotification if the view was moved out of the window but still had that window set as the host window. Also make sure this function doesn't do anything if the WebView is already closed. (-[WebView setHostWindow:]): Ditto.
- 9:31 AM Changeset in webkit [32873] by
- 1 edit1 copy in trunk/LayoutTests
Rubber-stamped by Adam Roben.
- fix test failure due to Windows' preference for Mac results over generic results
- platform/win/editing/selection/move-left-right-expected.txt: Copied from LayoutTests/editing/selection/move-left-right-expected.txt.
- 9:27 AM Changeset in webkit [32872] by
- 9 edits4 adds in trunk
Reviewed by Dave Hyatt.
- fix https://bugs.webkit.org/show_bug.cgi?id=18809 Forms with block level generated content and absolutely positioned labels break inline layout (fixed on reflow)
Test: fast/block/basic/adding-near-anonymous-block.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::addChildToFlow): When adding a floating or positioned object, if it follows an anonymous block, put it inside the anonymous block. When adding an inline, check if it comes after an anonymous block and put it in the anonymous block.
Reviewed by Dave Hyatt.
- test, updated test and updated results for https://bugs.webkit.org/show_bug.cgi?id=18809 Forms with block level generated content and absolutely positioned labels break inline layout (fixed on reflow)
- fast/block/basic/adding-near-anonymous-block.html: Added.
- media/video-controls-rendering.html: Changed to work around https://bugs.webkit.org/show_bug.cgi?id=18857 which now affects this test in its original form.
- platform/mac/css1/box_properties/clear-expected.txt:
- platform/mac/fast/block/basic/adding-near-anonymous-block-expected.checksum: Added.
- platform/mac/fast/block/basic/adding-near-anonymous-block-expected.png: Added.
- platform/mac/fast/block/basic/adding-near-anonymous-block-expected.txt: Added.
- platform/mac/fast/forms/input-align-image-expected.txt:
- platform/mac/media/audio-controls-rendering-expected.txt:
- platform/mac/media/video-controls-rendering-expected.txt:
- platform/mac/tables/mozilla/bugs/bug51140-expected.txt:
- 9:09 AM Changeset in webkit [32871] by
- 3 edits in trunk/WebCore
2008-05-05 Antti Koivisto <email@example.com>
Reviewed by Darin.
Speculative fix for <rdar://problem/5906790>
Crash in Loader::servePendingRequests() due to hash table being modified during iteration
I don't know how to reproduce this. It would require the load to fail (or succeed)
synchronously, something that should not usually happen.
- loader/loader.cpp: (WebCore::Loader::Loader): (WebCore::Loader::load): (WebCore::Loader::servePendingRequests): (WebCore::Loader::cancelRequests): (WebCore::Loader::Host::Host):
- loader/loader.h: (WebCore::Loader::Host::name):
- 6:43 AM UsingGitWithWebKit edited by
- fix repository url (diff)
- 3:43 AM Changeset in webkit [32870] by
- 3 edits in branches/squirrelfish/JavaScriptCore
2008-05-05 Maciej Stachowiak <firstname.lastname@example.com>
Reviewed by Oliver.
- fix some dumb mistakes in my last patch
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitPushScope): (KJS::CodeGenerator::emitGetPropertyNames):
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- 3:26 AM Changeset in webkit [32869] by
- 2 edits in trunk/WebKitTools
Ariya Hidayat <email@example.com>
In the Qt's DumpRenderTree, adjust the web view properly (because W3C SVG
tests expect to be 480x360)
- 2:59 AM Changeset in webkit [32868] by
- 2 edits in trunk/WebCore
Ariya Hidayat <firstname.lastname@example.com>
Disable SVG As Image support in the Qt port again, as it
requires more work. Right now the chrome client is
assumed to be a ChromeClientQt, which the SVG Image support
- 2:34 AM Changeset in webkit [32867] by
- 5 edits in branches/squirrelfish/JavaScriptCore
2008-05-05 Maciej Stachowiak <firstname.lastname@example.com>
Reviewed by Oliver.
- document opcodes relating to jumps, scopes, and property name iteration
Documented jmp, jtrue, false, push_scope, pop_scope, get_pnames,
next_pname and jmp_scopes.
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitJump): (KJS::CodeGenerator::emitJumpIfTrue): (KJS::CodeGenerator::emitJumpIfFalse): (KJS::CodeGenerator::emitPushScope): (KJS::CodeGenerator::emitNextPropertyName): (KJS::CodeGenerator::emitGetPropertyNames):
- VM/CodeGenerator.h:
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- kjs/nodes.cpp: (KJS::LogicalAndNode::emitCode): (KJS::LogicalOrNode::emitCode): (KJS::ConditionalNode::emitCode): (KJS::IfNode::emitCode): (KJS::IfElseNode::emitCode): (KJS::DoWhileNode::emitCode): (KJS::WhileNode::emitCode): (KJS::ForNode::emitCode): (KJS::ForInNode::emitCode): (KJS::WithNode::emitCode):
- 1:01 AM Changeset in webkit [32866] by
- 4 edits in branches/squirrelfish/JavaScriptCore
Bug 18749: SQUIRRELFISH: const support is broken
Cameron Zwarich <firstname.lastname@example.com>
Reviewed by Oliver.
Adds support for const during code generation.
Fixes 2 layout tests.
May 4, 2008:
- 11:48 PM Changeset in webkit [32865] by
- 5 edits in branches/squirrelfish/JavaScriptCore
2008-05-04 Maciej Stachowiak <email@example.com>
Reviewed by Geoff.
- document some more opcodes (and fix argument names)
Added docs for eq, neq, stricteq, nstriceq, less and lesseq.
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitEqual): (KJS::CodeGenerator::emitNotEqual): (KJS::CodeGenerator::emitStrictEqual): (KJS::CodeGenerator::emitNotStrictEqual): (KJS::CodeGenerator::emitLess): (KJS::CodeGenerator::emitLessEq):
- VM/CodeGenerator.h:
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- kjs/nodes.cpp: (KJS::LessNode::emitCode): (KJS::GreaterNode::emitCode): (KJS::LessEqNode::emitCode): (KJS::GreaterEqNode::emitCode): (KJS::EqualNode::emitCode): (KJS::NotEqualNode::emitCode): (KJS::StrictEqualNode::emitCode): (KJS::NotStrictEqualNode::emitCode): (KJS::CaseBlockNode::emitCodeForBlock):
- 11:46 PM Changeset in webkit [32864] by
- 10 edits in branches/squirrelfish/JavaScriptCore
2008-05-04 Geoffrey Garen <firstname.lastname@example.com>
Reviewed by Maciej Stachowiak.
More scaffolding for f.arguments.
Track the offset of the last call frame in the ExecState, so we can
produce a backtrace at any time.
Also, record numLocals, the sum of numVars + numParameters, in each code
block, to make updates to the ExecState a little cheaper than they
would be otherwise.
We now use numLocals in a bunch of places where we used to calculate
numVars + numParameters or -numVars - numParameters.
Reports are mixed, but all in all, this seems to be a wash on SunSpider.
- 10:30 PM Changeset in webkit [32863] by
- 5 edits in trunk/WebKit/wx
Reviewed by Kevin Ollivier.
Allow events to specify the ID of the particular wxWebView they are to be sent to.
- 9:46 PM Changeset in webkit [32862] by
- 1 edit2 adds in trunk/LayoutTests
2008-05-02 Antti Koivisto <firstname.lastname@example.com>
Reviewed by Mitz.
Test for <rdar://problem/5840475>
CrashTracer: [USER] 2 crashes in Safari at com.apple.WebCore: WebCore::RenderBlock::insertPositionedObject
- fast/transforms/container-transform-crash-expected.txt: Added.
- fast/transforms/container-transform-crash.html: Added.
- 9:44 PM Changeset in webkit [32861] by
- 2 edits in trunk/WebCore
2008-05-02 Antti Koivisto <email@example.com>
Reviewed by Mitz.
Fix <rdar://problem/5840475>
CrashTracer: [USER] 2 crashes in Safari at com.apple.WebCore: WebCore::RenderBlock::insertPositionedObject
Non-block objects can have transforms so containingBlock() could end up returning null.
RenderObject::container() needs to match.
Test: fast/transforms/container-transform-crash.html
- rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock): (WebCore::RenderObject::container):
- 9:42 PM Changeset in webkit [32860] by
- 2 edits in branches/squirrelfish/JavaScriptCore
Whoops, correctly handle properties that don't exist in the
symbol table.
Reviewed by Geoff
- 7:14 PM Changeset in webkit [32859] by
- 8 edits in branches/squirrelfish/JavaScriptCore
Add attribute information to SymbolTable as ground work for
various DontEnum and ReadOnly issues.
Reviewed by Geoff
- 7:05 PM Changeset in webkit [32858] by
- 6 edits in branches/squirrelfish/JavaScriptCore
2008-05-04 Geoffrey Garen <firstname.lastname@example.com>
Reviewed by Oliver Hunt.
More scaffolding for f.arguments.
Store the register file associated with an ExecState in the ExecState.
SunSpider reports no change.
- kjs/JSGlobalObject.h: (KJS::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): Moved registerFileStack above globalExec, so it gets initialized first. Removed remnants of old activation scheme.
- 6:48 PM Changeset in webkit [32857] by
- 2 edits in trunk/WebCore
2008-05-04 Sam Weinig <firstname.lastname@example.com>
Roll out r32851. It broke tiger builds.
- bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper): (WebCore::createDOMWrapper):
- 6:11 PM Changeset in webkit [32856] by
- 7 edits in branches/squirrelfish/JavaScriptCore
2008-05-04 Maciej Stachowiak <firstname.lastname@example.com>
Rubber stamped by Oliver.
- renamed a few opcodes and fixed assembly formatting to accomodate the longest opcode
equal --> eq
nequal --> neq
resolve_base_and_property --> resolve_with_base
resolve_base_and_func --> resolve_func
get_prop_id --> get_by_id
put_prop_id --> put_by_id
delete_prop_id --> del_by_id
get_prop_val --> get_by_val
put_prop_val --> put_by_val
delete_prop_val --> del_by_val
put_prop_index --> put_by_index
- VM/CodeBlock.cpp: (KJS::printUnaryOp): (KJS::printBinaryOp): (KJS::printConditionalJump): (KJS::CodeBlock::dump):
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitEqual): (KJS::CodeGenerator::emitNotEqual): (KJS::CodeGenerator::emitResolveWithBase): (KJS::CodeGenerator::emitResolveFunction): (KJS::CodeGenerator::emitGetById): (KJS::CodeGenerator::emitPutById): (KJS::CodeGenerator::emitDeleteById): (KJS::CodeGenerator::emitGetByVal): (KJS::CodeGenerator::emitPutByVal): (KJS::CodeGenerator::emitDeleteByVal): (KJS::CodeGenerator::emitPutByIndex):
- VM/CodeGenerator.h:
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- VM/Opcode.h:
- kjs/nodes.cpp: (KJS::ArrayNode::emitCode): (KJS::PropertyListNode::emitCode): (KJS::BracketAccessorNode::emitCode): (KJS::DotAccessorNode::emitCode): (KJS::EvalFunctionCallNode::emitCode): (KJS::FunctionCallResolveNode::emitCode): (KJS::FunctionCallBracketNode::emitCode): (KJS::FunctionCallDotNode::emitCode): (KJS::PostIncResolveNode::emitCode): (KJS::PostDecResolveNode::emitCode): (KJS::PostIncBracketNode::emitCode): (KJS::PostDecBracketNode::emitCode): (KJS::PostIncDotNode::emitCode): (KJS::PostDecDotNode::emitCode): (KJS::DeleteResolveNode::emitCode): (KJS::DeleteBracketNode::emitCode): (KJS::DeleteDotNode::emitCode): (KJS::TypeOfResolveNode::emitCode): (KJS::PreIncResolveNode::emitCode): (KJS::PreDecResolveNode::emitCode): (KJS::PreIncBracketNode::emitCode): (KJS::PreDecBracketNode::emitCode): (KJS::PreIncDotNode::emitCode): (KJS::PreDecDotNode::emitCode): (KJS::ReadModifyResolveNode::emitCode): (KJS::AssignResolveNode::emitCode): (KJS::AssignDotNode::emitCode): (KJS::ReadModifyDotNode::emitCode): (KJS::AssignBracketNode::emitCode): (KJS::ReadModifyBracketNode::emitCode): (KJS::ConstDeclNode::emitCodeSingle): (KJS::ForInNode::emitCode): (KJS::TryNode::emitCode):
- 4:29 PM Changeset in webkit [32855] by
- 3 edits3 adds in branches/squirrelfish
Fix assertion when accessing arguments object with too many arguments provided
Reviewed by Maciej
The arguments constructor was assuming that the register offset given for argv
was an absolute offset into the registerfile, rather than the offset from the
frame. This patches corrects that issue.
- 3:03 PM Changeset in webkit [32854] by
- 3 edits2 adds in trunk
Reviewed by Sam Weinig.
- fix https://bugs.webkit.org/show_bug.cgi?id=18879 <rdar://problem/5909481> Reproducible crash when removing a gradient
Test: fast/gradients/crash-on-remove.html
- css/CSSImageGeneratorValue.cpp: (WebCore::CSSImageGeneratorValue::CSSImageGeneratorValue): (WebCore::CSSImageGeneratorValue::addClient): Added a call to ref() the value. (WebCore::CSSImageGeneratorValue::removeClient): Added code to deref() the value.
Reviewed by Sam Weinig.
- test for https://bugs.webkit.org/show_bug.cgi?id=18879 <rdar://problem/5909481> Reproducible crash when removing a gradient
- fast/gradients/crash-on-remove-expected.txt: Added.
- fast/gradients/crash-on-remove.html: Added.
- 2:52 PM Changeset in webkit [32853] by
- 5 edits in trunk/LayoutTests
2008-05-04 Sam Weinig <email@example.com>
Reviewed by Maciej Stachowiak.
Don't print out the full url.
- fast/dom/Window/dom-access-from-closure-iframe-expected.txt:
- fast/dom/Window/dom-access-from-closure-window-expected.txt:
- fast/dom/Window/resources/dom-access-from-closure-iframe-child.html:
- fast/dom/Window/resources/dom-access-from-closure-window-child.html:
- 2:52 PM Changeset in webkit [32852] by
- 2 edits in trunk/WebKit/mac
Make parameters match for WebChromeClient::addMessageToConsole()
Reviewed by John.
- WebCoreSupport/WebChromeClient.h: (WebChromeClient::addMessageToConsole): Renamed sourceID parameter to sourceURL to match implementation in WebChromeClient.mm.
- 2:29 PM Changeset in webkit [32851] by
- 2 edits in trunk/WebCore
2008-05-03 Sam Weinig <firstname.lastname@example.com>
Reviewed by Mark Rowe.
Move createDOMWrapper(JSObject* object) out of the KJS namespace and into
the WebCore namespace now that the required compilers don't freak out about
this anymore.
- bindings/objc/DOMUtility.mm: (WebCore::createDOMWrapper):
- 11:27 AM Changeset in webkit [32850] by
- 2 edits in branches/squirrelfish/JavaScriptCore
2008-05-04 Geoffrey Garen <firstname.lastname@example.com>
Rubber stamped by Sam Weinig.
Cleaned up Machine.cpp according to our style guidelines: moved static
data to the top of the file; moved stand-alone functions below that;
moved the Machine constructor above other Machine member functions.
May 3, 2008:
- 11:36 PM Changeset in webkit [32849] by
- 5 edits in trunk
Reviewed by Sam.
onchange events don't seem to fire for input[type=range] controls.
Fire changeEvent when clicking the slider outside the current
thumb position.
- 6:04 PM Changeset in webkit [32848] by
- 2 edits in trunk/WebCore
2008-05-03 Sam Weinig <firstname.lastname@example.com>
Reviewed by Mark Rowe.
Remove unused enums from JSDOMWindowBase.
- bindings/js/JSDOMWindowBase.h: (WebCore::JSDOMWindowBase::):
- 5:59 PM Changeset in webkit [32847] by
- 2 edits in trunk/WebCore
2008-05-03 Sam Weinig <email@example.com>
Real build fix.
- WebCore.xcodeproj/project.pbxproj:
- 5:48 PM Changeset in webkit [32846] by
- 2 edits in trunk/WebCore
2008-05-03 Sam Weinig <firstname.lastname@example.com>
Build fix.
- bindings/js/kjs_events.cpp: (WebCore::JSAbstractEventListener::handleEvent):
- 5:36 PM Changeset in webkit [32845] by
- 1 edit16 adds in trunk/LayoutTests
2008-05-03 Sam Weinig <email@example.com>
Reviewed by Dan Bernstein.
Add tests that show our behavior when using closures from a global object
whose frame has been navigated.
Related to https://bugs.webkit.org/show_bug.cgi?id=17249.
- fast/dom/Window/closure-access-after-navigation-iframe-expected.txt: Added.
- fast/dom/Window/closure-access-after-navigation-iframe.html: Added.
- fast/dom/Window/closure-access-after-navigation-window-expected.txt: Added.
- fast/dom/Window/closure-access-after-navigation-window.html: Added.
- fast/dom/Window/dom-access-from-closure-iframe-expected.txt: Added.
- fast/dom/Window/dom-access-from-closure-iframe.html: Added.
- fast/dom/Window/dom-access-from-closure-window-expected.txt: Added.
- fast/dom/Window/dom-access-from-closure-window.html: Added.
- fast/dom/Window/resources/closure-access-after-navigation-iframe-child-1.html: Added.
- fast/dom/Window/resources/closure-access-after-navigation-iframe-child-2.html: Added.
- fast/dom/Window/resources/closure-access-after-navigation-window-child-1.html: Added.
- fast/dom/Window/resources/closure-access-after-navigation-window-child-2.html: Added.
- fast/dom/Window/resources/dom-access-from-closure-iframe-child.html: Added.
- fast/dom/Window/resources/dom-access-from-closure-window-child.html: Added.
- fast/dom/Window/resources/notify-opener-done.html: Added.
- fast/dom/Window/resources/notify-parent-done.html: Added.
- 5:02 PM Changeset in webkit [32844] by
- 23 edits2 moves in trunk/WebCore
2008-05-03 Sam Weinig <email@example.com>
Rubber-stamped by Geoffrey Garen.
Rename JSDOMWindowWrapper to JSDOMWindowShell.
- 2:40 PM Changeset in webkit [32843] by
- 2 edits in branches/squirrelfish/JavaScriptCore
2008-05-03 Maciej Stachowiak <email@example.com>
Reviewed by Sam.
- fix accidental breakage from last patch
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- 2:08 PM Changeset in webkit [32842] by
- 7 edits in branches/squirrelfish/JavaScriptCore
2008-05-03 Maciej Stachowiak <email@example.com>
Reviewed by Geoff.
- a bunch more opcode documentation and corresponding parameter name fixes
I renamed a few opcodes:
type_of --> typeof (that's what the JS operator is named)
instance_of --> instanceof (ditto)
create_error --> new_error (for consistency with other new_* opcodes)
I documented the following opcodes:
- load
- new_object
- new_array
- new_regexp
- mov
- pre_inc
- pre_dec
- post_inc
- post_dec
- to_jsnumber
- negate
- bitnot
- not
- instanceof
- typeof
- in
- new_func
- new_funcexp
- new_error
I also fixed formatting on some existing opcode docs.
- VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitMove): (KJS::CodeGenerator::emitNot): (KJS::CodeGenerator::emitPreInc): (KJS::CodeGenerator::emitPreDec): (KJS::CodeGenerator::emitPostInc): (KJS::CodeGenerator::emitPostDec): (KJS::CodeGenerator::emitToJSNumber): (KJS::CodeGenerator::emitNegate): (KJS::CodeGenerator::emitBitNot): (KJS::CodeGenerator::emitInstanceOf): (KJS::CodeGenerator::emitTypeOf): (KJS::CodeGenerator::emitIn): (KJS::CodeGenerator::emitLoad): (KJS::CodeGenerator::emitNewObject): (KJS::CodeGenerator::emitNewArray): (KJS::CodeGenerator::emitNewRegExp): (KJS::CodeGenerator::emitNewError):
- VM/CodeGenerator.h: (KJS::CodeGenerator::scopeDepth): (KJS::CodeGenerator::addVar):
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- VM/Opcode.h:
- kjs/nodes.cpp: (KJS::Node::emitThrowError): (KJS::RegExpNode::emitCode): (KJS::TypeOfValueNode::emitCode): (KJS::UnaryPlusNode::emitCode): (KJS::NegateNode::emitCode): (KJS::BitwiseNotNode::emitCode): (KJS::LogicalNotNode::emitCode): (KJS::InstanceOfNode::emitCode): (KJS::InNode::emitCode):
- 1:53 PM Changeset in webkit [32841] by
- 2 edits2 adds in branches/squirrelfish/JavaScriptCore
2008-05-03 Maciej Stachowiak <firstname.lastname@example.com>
Reviewed by Geoff and Sam.
- generate HTML bytecode docs at build time
- DerivedSources.make:
- docs: Added.
- docs/make-bytecode-docs.pl: Added.
- 1:35 PM Changeset in webkit [32840] by
- 7 edits in branches/squirrelfish/JavaScriptCore
2008-05-03 Geoffrey Garen <firstname.lastname@example.com>
Reviewed by Sam Weinig.
Update ExecState::m_scopeChain when switching scope chains inside the
This fixes uses of lexicalGlobalObject, such as, in a subframe
alert(top.makeArray() instanceof Array ? "FAIL" : "PASS");
and a bunch of the security failures listed in
https://bugs.webkit.org/show_bug.cgi?id=18870. (Those tests still fail,
seemingly because of regressions in exception messages).
SunSpider reports no change.
- VM/Machine.cpp: Factored out scope chain updating into a common function that takes care to update ExecState::m_scopeChain, too.
- kjs/ExecState.h: I made Machine a friend of ExecState so that Machine could update ExecState::m_scopeChain, even though that value is read-only for everyone else.
- kjs/JSGlobalObject.h: (KJS::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): Changed this client to be a little friendlier to ExecState's internal storage type for scope chain data.
- 12:36 PM Changeset in webkit [32839] by
- 2 edits in branches/squirrelfish/JavaScriptCore
2008-05-03 Geoffrey Garen <email@example.com>
Reviewed by Sam Weinig.
Fixed https://bugs.webkit.org/show_bug.cgi?id=18876
Squirrelfish: ScopeChainNode leak in op_jmp_scopes.
SunSpider reports no change.
- VM/Machine.cpp: (KJS::Machine::privateExecute): Don't construct a ScopeChain object, since the direct threaded interpreter will goto across its destructor.
- 2:14 AM Changeset in webkit [32838] by
- 8 edits in branches/squirrelfish/JavaScriptCore
2008-05-03 Geoffrey Garen <firstname.lastname@example.com>
Reviewed by Oliver Hunt.
A bit more efficient fix than r32832: Don't copy globals into function
register files; instead, have the RegisterFileStack track only the base
of the last *global* register file, so the global object's register
references stay good.
SunSpider reports a .3% speedup. Not sure what that's about.
- 12:20 AM Changeset in webkit [32837] by
- 6 edits in branches/squirrelfish/JavaScriptCore
Bug 18864: SquirrelFish: Support getter and setter definition in object literals
Reviewed by Maciej
Add new opcodes to allow us to add getters and setters to an object. These are
only used by the codegen for object literals.


text:
Perspectives 161: Tim Lee
Artist Tim Lee doesnt want to be a celebrity he wants to be celebrities. In his solo exhibition Perspectives 161: Tim Lee, the photographer imagines himself as actors, musicians and athletes. In one photo, he re-creates the classic image of actor/comedian Steve Martin holding a banjo and wearing a headband made to look like an arrow is going through his head. In others, he rocks out like Neil Young or uses digital imaging to appear to be bending over backwards like flexible frontman Iggy Pop. In the video installation Aria: Goldberg Variations, Glenn Gould, two separate screens show Lees hand mimicking the work of the famous pianist. With these works and more, Lee not only gets to play pretend, but to question roles usually reserved to trained professionals. The show runs 10 a.m. to 5 p.m. Tuesdays and Wednesdays, 10 a.m. to 9 p.m. Thursdays, 10 a.m. to 5 p.m. Fridays and Saturdays, and noon to 5 p.m. Sundays. Through July 13. Contemporary Arts Museum Houston, 5216 Montrose. For information, call 713-284-8250 or visit www.camh.org. Free.
Tuesdays-Saturdays. Starts: May 16. Continues through July 13, 2008
Get the Things to Do Newsletter
Sign up for our weekly guide to events in Houston, and never be bored again. With suggestions for every day of the week, our recommendations will keep you busy on any budget.
Upcoming Events
Disney Presents The Lion King (Touring)
TicketsTue., Jun. 27, 7:30pm
Mexico National Football Team vs. Ghana
TicketsWed., Jun. 28, 8:00pm
TicketsThu., Jun. 29, 8:00pm
Local Brews, Local Grooves
TicketsSat., Jul. 1, 3:00pm
Sponsor Content

subset: commoncrawl


text:
ED Magedson – Founder
Ripoff Report
Kollagen Intensiv129 Roweland Dr. Johnson City, Tennessee USA
Kollagen Intensiv Leading Edge Health, SkinCeption After use, my skin stayed dry. Susan said use moisturizer after application. Skin still dry and wrinkly. Johnson City Tennessee
Does your business have a bad reputation?
Fix it the right way.
Corporate Advocacy Program™
Paid $4.95 s/h by cc on Oct.24, 2013. Was told every 5th of month will be charged $99.95. I can order 2 jars each month@ $76.20, including s&h. Claims my next order will include an exfoliator. My skin is drier than before using this product, no visual change, although I was told to keep using a moisturizer after applying Kollagen Intensive. Not happy and do not want them to take any money from my bank account.
This report was posted on Ripoff Report on 01/26/2014 12:41 AM and is a permanent record located here: http://www.ripoffreport.com/reports/kollagen-intensiv/johnson-city-tennessee-37601/kollagen-intensiv-leading-edge-health-skinception-after-use-my-skin-stayed-dry-susan-s-1118507. The posting time indicated is Arizona local time. Arizona does not observe daylight savings so the post time may be Mountain or Pacific depending on the time of year.
Ripoff Report has an exclusive license to this report. It may not be copied without the written permission of Ripoff Report. READ: Foreign websites steal our content
Click Here to read other Ripoff Reports on Kollagen Intensiv
If you would like to see more Rip-off Reports on this company/individual, search here:Search Tips
In order to assure the best results in your search:
Advertisers above have met our
strict standards for business conduct.


text:
If you want some nice informative videos to show your clients, the Fsecure youtube channel is very nice and gives a great deal of informative videos you can use for your clients.
You can use a service like Vixy to make them portable – http://vixy.net/ (Chris Rue told me about that site) but if you want a higher resolution version you can get it from the excellent fsecure blog site – http://www.f-secure.com/weblog/archives/archive-072007.html#00001232
It's a great resource to educate the end users as to why spam works…. and why this is big business these days.


text:
Location: Calgary
What I drive:
Posts/Day: 0.05
Trader Rating: (25)
User Rating: 100%
Hi all, I am looking to see if any of you have a Conroe core Socket 775 CPU that you don't want and could pass on to me for free.
Here's my situation: I was given a motherboard out of a Compaq, Asus IPILP-LC, without a CPU, but I have on hand a Pentium D 940 Presler core. On the motherboard's list of supported CPUs a Pentium D 9xx Presler is listed but somehow it doesn't work. It simply gave an unsupported CPU error and shuts down. I wonder if I got a bad CPU or if the specs aren't quite what they're supposed to be. I doubt the CPU is bad because I pulled it out of a working system.
If you have any of the following CPUs that you want to give away for free, please PM me and let me know.
Core 2 Duo E4x00 with Dual Core technology (Conroe) up to E4400
Pentium E2000 series (Conroe) up to E2160
Pentium D 9xx with Dual Core technology (Presler) up to 960
Pentium 4 6x1 series (Cedar Mill) up to 661
Celeron 4xx series (Conroe) up to 440
Celeron D 3xx series (Cedar Mill) up to 365
Celeron D 3xx series (Prescott) up to 355
Thanks for reading!
Report this post | IP: Logged
Location: Calgary
What I drive:
Posts/Day: 0.05
Trader Rating: (9)
User Rating: 96%
I assume you updated the BIOS so it will actually support that CPU correct?
That would be the first/only step you need if you did not.
Not sure why the HP page for that system does not have a list of files to download, but a quick google found this:
Fixes CMOS defaults reloading feature.
Updates CPU microcode.
Fixes SMART error message during POST.
Fixes BIOS setup screen overlap issues.
Fixes PATA/SATA device detection display issue with 'NONE' string displayed in BIOS main setup.
Improves HP PMD 500GB or 750GB boot time.
Improves audio add-in card detection.
Improves S3 resume time.
I would check the version of the BIOS installed and go from there. It would not surprise me if you are very far back in the versions (1.x/2.x) where the link above is for v 5.19 BIOS.
You should be able to extract the BIOS update from the RomPaq so you don't need to install Windows first to install.
Last edited by Greek Wizard on 02-27-2012 at 09:17 PM
Thanks for mentioning this. The BIOS is actually 5.19 - shown briefly on the boot-up, then it displays the "unsupported CPU - shutting down in a few seconds" message. This is with my Pentium D 940 installed.
Location: okotoks
What I drive:
Posts/Day: 0.05
Trader Rating: (12)
User Rating: 100%
if your still looking i have a p4 531 i would trade for your 940
Your P4 531 won't work on my board. P4 6x1 works though. You got anything like that?
Originally posted by Zorac
if your still looking i have a p4 531 i would trade for your 940
sorry, no, just a pair of 531s.
sorry, no, just a pair of 531s.
Location: Calgary
What I drive: '03 ep3
Posts/Day: 0.13
Trader Rating: (25)
User Rating: 99%
With these work?
Sorry, I'm afraid not, as the motherboard requires P4 6x1. Your SL7Z8 is a P4 640, so I don't think it'll work. Thanks for following up with this thread though!
Location: Calgary, Ab
What I drive: 2009 G37x
Posts/Day: 0.19
Trader Rating: (114)
User Rating: 94%
Any of these work? Not my ad, just poking around for you:
Still looking for CPU, but can pay a few bucks for your trouble. Please let me know what you got. Prefer the Conroe CPUs, but as long as you have something on this list, I'm not gonna be picky. (I know, beggars can't be choosers!)


text:
Thermage® Before and After Pictures by Michael Janiszewski, MD
Patient had Thermage, one treatment,of lower abdomen.
Patient DetailsSex: Female
Procedure performed on: Head, Face
Before and After Pictures
Click on an Image to View Full Size
Performed by Michael Janiszewski, MD, Glastonbury, Connecticut
Contact a Doctor
Looking for doctors who perform Thermage®? Fill out the form below to find one in your area now.
Share This Page
Related Galleries
Click on a thumbnail to view gallery.Click here to view all Before & After gallery cases related to Thermage®


text:
ED Magedson – Founder
Ripoff Report
Excell internet ServiceInternet USA
Exede internet Service Satellite Sales Center Excede does not care about pr ospective customers getting ripped off in their name Internet
Does your business have a bad reputation?
Fix it the right way.
Corporate Advocacy Program™
I called 855-200-9172 to sign up for Hughesnet which would have cost nothing to install, I spoke to a young man named Joe. The first time I called I was not able to activate my credi t card so I told him I would have to call back. The next day I called back to give him my debit card and was told they would not charge the 40.00 just needed to make sure card was valid. Then Joe stated hugesnet would not allow it unless I purchased the equipment.
I told him I had already gone through this before and there was no problem, it was just supposed to be a 40.00 hold, he sttd they also had Exede which was far faster and all arouhd better than Hugesnet but it had a set up fee of 49.99.
I told him okay and was happy to get the faster of the two. He asked for my debit number and I gave it to him, then I asked when I would have to pay again. He tried not to answer but that made me feel uncomfortable. I continued to push it until he stated it would be about 3 days after installation and it would be 60.00.
I told him I would not get paid again by then and he offered to delay installation, I told him I was working online and needed it. He stated nothing he could do. I asked him not to charge my card and cancel the order. I asked him if they would charge it, he stated "I don't think so, but if they do they will refund it in 7 to 14 days."
I told him I did not want to wait 14 days. I hung up with him and called my debit card, it had already been charged while we were speaking. I called the number back and asked for a supervisor, the man stated his name was Ernie and he was the Supervisor. I asked abut Joe and he said he worked in a different Office which I thought was strange because I had already spoken to him there twice.
The call was sent to Exede and the person I spoke to was in billing, she was very good at escalated calls and calmed me down, I told her a customer has a right to recind an order and not be charged, if that is the way it is set up they by law have to let the consumer know. She said she would escalate call to her supervisor, while waiting te fcall was disconnected.
Icalled back and talked to another young lady who just continued to tell me the money would be returned in 7 to 14 days, I asked her why I had to wait and she said because it takes that long. I finally requested to speak to her supervisor who would not even come t the phone. I refused to discuss it with her anymore and told her had the right to speak to someone who migh t be able to handle i t.
she finally got a Supervisor and he was very rude, I told him as a consumer I had the right to resolve this he stated it would be 1 to 2 weeks for refund, I old him a chargeback cou7ld be done in ten minutes, he stated they did not do charge backs, they refund back on the card wi thin 7 to 10 days.
Ever heard of a chargeback???? It means you put the money back on the card, the ony reson it would take that long is if they plan to fight it, they better not I did not recieve any services and I was straight out lied to about everything from the beginning. There was no problem wi th Hugesnet Joe just got more money for signing exede customers.
I am very angry at the rude and nonchalant way I was treated and they are trying to break into the business? Not like that. If I was starting a new Company, I would want a marketing Company that was up front withs my consumers, no tone that is going to misrepresent to get people to sign up. Exede didn't seem to have a problem with this so what would they be like if I had kept them as a provider?
There was no customer Service to it, I was treated like a sucker and while I had been blaming the Marketing Company I wonder if Exededid not know what was going on all along. For a new up and coming provider this will not help you grow. I have been in Customer Service and related fields for 25 years and I have never seen a new Company come out of the door by being rude specially when their reputatoin is involved.
This report was posted on Ripoff Report on 07/17/2013 02:11 PM and is a permanent record located here: http://www.ripoffreport.com/reports/excell-internet-service/internet/exede-internet-service-satellite-sales-center-excede-does-not-care-about-pr-ospective-cus-1067842. The posting time indicated is Arizona local time. Arizona does not observe daylight savings so the post time may be Mountain or Pacific depending on the time of year.
Ripoff Report has an exclusive license to this report. It may not be copied without the written permission of Ripoff Report. READ: Foreign websites steal our content
Click Here to read other Ripoff Reports on Excell internet Service
If you would like to see more Rip-off Reports on this company/individual, search here:Search Tips
In order to assure the best results in your search:
Advertisers above have met our
strict standards for business conduct.


text:
The Microsoft Surface is a well-constructed tablet, no doubt. Combined with a closed Touch or Type Cover, the screen can be decently protected from bumps and scratches. But I wouldn't want to drop either Surface, especially the costlier Pro – they're bound to come away with some scrapes.
You could try to protect your Surface by using it as a desktop and never taking it anywhere, but that's no fun to do with a tablet. So why not try a case for protection? Whichever Surface model you own, an online retailer called Bear Motion has you covered. Their Elsse Premium Folio Cases for both the Surface RT and Pro come in a wide variety of colors. Check out several of those colors in our full review with video!


text:
These are really nice patterns - thanks for sharing! Welcome from Delaware.
Welcome to the Quilting Board!
These are really nice patterns - thanks for sharing! Welcome from Delaware.
A Very Warm Welcome from Georgia. Thanks ever so for the wonderful ideas. You are so right too, you are not alone wondering how to quilt the OBW. Bookmarked this one!
Welcome from So.Minnesota! Thanks for the templates. How helpful. Looking forward to seeing your finished products...only on this QB!! YES!!
Thank you so much for all this work that you did and are sharing with us.This is definitely a keeper for me.
Thanks much for sharing!!! I did a OBW and did some echo quilting leaving some of the triangles blank. Nothing as pretty as this.
How generous and thoughtful of you. I'm bookmarking this immediately. Thanks so much.
Thanks for your generosity
Thank you so much for these ideas! I especially love the butterflies!


text:
The End!
Trip Start Oct 30, 2005
59Trip End Jun 19, 2006
Map your own trip!
Loading Map
Loading Map
Map Options
Show trip route
Hide lines
Turkey has been magnificent, and it looks like I'll be back here working this year. Having done almost none of the sights, that may well be a good chance to catch the things I've missed, but no doubt I'll pass them by again. There's too many good people to meet here - what's a traveller to do??
Tomorrow I fly out of Istanbul, to Rome. Asia will be behind me; Europe and dear friends await. We have a couple of days in Rome, then a week at the apartment in Florence. Several beery days in World Cup Germany are interspersed between my leaving Italy, and my arriving in London, and that is going to be a hell of a good time.
So my solo wanderings have come to an end, and with it this travelogues. No doubt that will come as a blessed relief to most of you, but if anyone is still reading, than thanks, and I hope you've enjoyed it all. I'll keep putting my photos up, and probably do an Italy/Germany round-up later, so look out. :-)
I read a wonderful quote the other day: "A tourist doesn't know where he's been. A traveller has no idea where he is going."
I kinda like that. It seems to fit pretty well.
Thanks you guys, take care, and everyone keep in touch please! I may not be writing much more for a while, but I love to hear from all of you.
All my love, and big hugs.
El Condor xo


text:
I read with great interest Tuesday's article concerning staffing levels in the Indiana Area School District. I was particularly interested in the case Patrick Snyder was making to the board for the prevention of staff reductions in health and physical education.
I fully understand and agree with his professional concerns.
However, this scenario is nothing new. Members of our profession have spent untold hours and great amounts of energy throughout many years trying to overcome problems that ultimately prevent health and physical education from being rightfully accepted as an academic component of our education process.
Historically, I have been involved in academics as a student, coach and professor for well over a half-century. These same problems continue to resurface. Everyone agrees that education is important and yet we seldom adequately fund it. Many people think of education as a business, but it is not a business. It is not how many bolts you manufacture, or how many bridges you build or how many cars you sell.
The product is different and so, the budget considerations should differ accordingly. This process will probably lead to a different "bottom line." We should have a broad-base source of revenue to properly fund education. We should no longer have to rely on real-estate taxes since the total budget is too large for this type of tax.
Subject areas other than reading, writing, math and science are generally not considered academic and are often thought of as frills. Health and physical education is especially vulnerable to cuts since many people don't understand that it is "Education through the Physical" and, as such, is an important component in the complete education of the individual.
For many years I would ask my students to list the five most important things in their life.
There was never a list that didn't include health, which was often listed as the most important.
I think it is so ironic that there is so much concern about the state of our national well-being and health care costs, and yet we are constantly looking to make cuts in programs that have been developed to teach individuals how to care for themselves.
This comes at a time when we should be increasing, not decreasing our support. So, if education is as important as we say it is, then we should render adequate support.
Dr. Edward Sloniger
Retired IUP professor


text:
- Cuisine: Chinese
- Alcohol: BYOB
- Price: $$
- Accepts Credit Cards: Yes
Philly is the Late-Night Capital of the US
According to the September issue of Esquire, Philadelphia is the Late-Night Capital of these here United States. The issue's late-night eats guide contains essays about the difference between truck stops and diners, the glory that is poutine (I'd say we agree), and tons of recipes for manly food to be eaten in the wee hours of the morning. Esquire even lists all the best late-night foods from all over America– from egg rolls in Chicago to fried chicken in Louisville– but without mentioning a single food from Philly. Why? Because we got our own article about why we're the best ever, that's why.