Make it more obvious when we need to copy the file path.
So that it's more obvious when we need to copy the file path.
Coverage increased (+0.0009%) to 92.317% when pulling 4c53909 on suzaku:highlight-file-loc into ffb583a on pytest-dev:master.
Thanks for the screenshot @nicoddemus! Shouldn't this go to features though?
Good point, I could rebase it tomorrow before merging though.
Seems to be related to executing the pyi_rth_pkgres internal module from PyInstaller. Perhaps @codewarrior0 or @htgoebel have any hints at what might be the problem?
That's a setuptools bug, see pypa/setuptools#702 - pypa/setuptools#703 was now merged, and seeing how often setuptools is released I bet there will be a new release very soon.
Thanks for replying. Let me know if there's anything I can do to fix the failing build.
assert tw.lines == " def f():"
assert tw.lines == "> g(3)"
@suzaku just a question, why did you changed those tests? Your change to the terminal writer required those to be changed?
@nicoddemus Yes, otherwise the tests would fail. After I used write to print out the highlighted file path, the tests complained that there's no write method on the TWMock object. So I added a write method for TWMock and the corresponding way to check writes.
I think there must be a better way to do this, maybe I can refactor these tests and eliminate replace TWMock with a mock.Mock later in another pull request?
Closing in favor of #1781. Thanks again @suzaku!