TST: indexing/test_floats.py::TestFloatIndexers::test_scalar_non_numeric
precursor to #25750

This test has some commented out code with a pytest.raises not used as a context manager.

The goal here is primarily to remove the commented out code.

some refactoring but not enough to allow full parametrization.
