 He served in the Spanish–American War, in the Mexican Border Expedition, and in the First and Second World Wars.He was a burgess of East Waynesburg from 1902 to 1905, solicitor of Greene County from 1908 to 1910 and again from 1916 to 1920.He served as auditor general of Pennsylvania from 1925 to 1929 and State treasurer from 1929 to 1933.