"When You're Smiling" is a popular song written by Larry Shay, Mark Fisher and Joe Goodwin. First published in 1928, it bears resemblance to the Spanish Canción "Amapola" by José María Lacalle García. Early popular recordings were by Seger Ellis (1928), Louis Armstrong (1929), and Ted Wallace & His Campus Boys (1930). Other notable recordings Andy Williams released a version on his 1963 album, Days of Wine and Roses and Other TV Requests. Bob and Alf Pearson in 1930 for Piccadilly Records Caroline Henderson for her album No.8 (2008). Cliff Bruner's Texas Wanderers – recorded September 13, 1938, it reached the country charts in 1939. This version was sung by singer pianist Moon Mullican. Dean Martin (1952). Later, he sometimes parodied it as "When You're Drinkin'". Doris Day – for her album What Every Girl Should Know (1960) Dr. John – for his album Ske-Dat-De-Dat: The Spirit of Satch (2014) Duke Ellington – several recordings in 1930. Ella Fitzgerald – acc. by Lou Levy (p), Max Bennett (sb), Gus Johnson (dm) live Teatro Sistina, Rome, Italy — Ella in Rome: The Birthday Concert (1958) Erroll Garner – in his album Piano Moods (1950). Fats Domino – recorded in September 1967; included in his album Fats (1971). Frank Sinatra – Sing and Dance with Frank Sinatra (1950) and also for his album Sinatra's Swingin' Session!!! (1961). Sinatra also sang the song in the film Meet Danny Wilson (1952). Frankie Laine – performed the song in the film When You're Smiling (1950). Jack Hylton – recorded June 6, 1930. Judy Garland performed the song at the Judy at Carnegie Hall concert in 1961. Julia Lee – The Chronological Julia Lee 1947 (2005). Louis Armstrong – Satchmo: A Musical Autobiography (1956). In his recording from 1929, Armstrong tried to adapt the "white" style of Guy Lombardo through the inclusion of an expansive saxophone section sound. Louis Prima – The Call of the Wildest (1957). Michael Bublé – for his album BaBalu (2001). 17 years later he re-recorded it for his album Love Mickey Mouse (Bret Iwan) – The MousePack – Mickey and Friends Singing Standards (2022) Nat Gonella and His Trumpet — recorded November 15, 1932. Nat King Cole – Ramblin' Rose (1962) Patti Page – Page Two – Sings a Collection of Her Most Famous Songs (1957). Perry Como – a single release, recorded November 25, 1947. Rufus Wainwright recorded the song